Date: Mon, 5 May 2003 23:46:01 +0300 From: "Petri Helenius" <pete@he.iki.fi> To: "John Baldwin" <jhb@FreeBSD.org> Cc: sos@FreeBSD.org Subject: Re: kthread_exit and giant Message-ID: <02ed01c31347$56f023d0$932a40c1@PHE> References: <XFMail.20030505160152.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > The kthread is supposed to acquire Giant before calling kthread_exit(). > Actually, my guess is that the ar kthread needs to acquire Giant for the > lifetime of the thread. I have an untested patch locally: > I thought the lifetime of the thread is the duration of the rebuild process? Which can be minutes to hours. Locking giant for that kind of time does not sound right, so locking it just before thread exit sounds like the right thing to do, as long as the code othervise keeps critical sections locked. Pete
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?02ed01c31347$56f023d0$932a40c1>