From owner-cvs-src@FreeBSD.ORG Fri Aug 4 07:19:21 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9990716A513; Fri, 4 Aug 2006 07:19:21 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 53A7043D53; Fri, 4 Aug 2006 07:19:18 +0000 (GMT) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k747JAmw013194; Fri, 4 Aug 2006 11:19:10 +0400 (MSD) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k747J90p013193; Fri, 4 Aug 2006 11:19:10 +0400 (MSD) (envelope-from yar) Date: Fri, 4 Aug 2006 11:19:09 +0400 From: Yar Tikhiy To: pdeuskar@FreeBSD.org Message-ID: <20060804071909.GS97316@comp.chem.msu.su> References: <200608031905.k73J55D2061870@repoman.freebsd.org> <44D29FB6.9090209@freebsd.org> <20060804012514.GA63379@what-creek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060804012514.GA63379@what-creek.com> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/em if_em.c if_em.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2006 07:19:21 -0000 On Fri, Aug 04, 2006 at 01:25:14AM +0000, John Birrell wrote: > On Thu, Aug 03, 2006 at 06:15:34PM -0700, Colin Percival wrote: > > Prafulla Deuskar wrote: > > > Modified files: > > > sys/dev/em if_em.c if_em.h > > > Log: > > > Revert back changes to made in rev 1.109 of if_em.c which were unnecessary. > > > This makes it easier for us to get the changes into -current and to -stable quickly. > > > > I assume you've discussed this with glebius, who made the original changes; in > > the future, please add an "Approved by:", "No objections from:", or "Discussed > > with:" line to backout commits to make this more clear. > > Also Pyun had made a fix for the bus_dmamap_unload problem we see on sun4v. This > appears to have been backed out amongst what appears to be largely a white-space > change. > > Are you prepared to do the work to solve the bus_dmamap_unload again? As a general remark, it is a very good idea to keep large style(9) sweeps separate from actual code changes even if they are tiny. Changing style(9) shouldn't alter the binary code produced, and this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1). Of course, changing line numbers will affect debug info, but the latter can be strip(1)'ed. In the case under discussion, I'd compare if_em.o with its former version to make sure no code changed. -- Yar