Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Oct 2021 23:58:23 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 4415ec04a461 - stable/13 - cxgbei: Remove invalid assertion.
Message-ID:  <202110292358.19TNwN4v003701@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=4415ec04a4615ac4a0322ead183d97d06c955059

commit 4415ec04a4615ac4a0322ead183d97d06c955059
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2021-07-19 22:36:31 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2021-10-29 23:11:34 +0000

    cxgbei: Remove invalid assertion.
    
    A non-placed PDU can be delivered by CPL_RX_ISCSI_CMP in the middle of
    a burst of placed PDUs (received via DDP) in which case the rcv_nxt
    will not match the start of the non-placed PDU.
    
    Reported by:    Jithesh Arakkan @ Chelsio
    Sponsored by:   Chelsio Communications
    
    (cherry picked from commit 4a7d15ebb6afe1b662afd2fde0ed2725790a1ba1)
---
 sys/dev/cxgbe/cxgbei/cxgbei.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/dev/cxgbe/cxgbei/cxgbei.c b/sys/dev/cxgbe/cxgbei/cxgbei.c
index c70bda7e0436..5135fc68d197 100644
--- a/sys/dev/cxgbe/cxgbei/cxgbei.c
+++ b/sys/dev/cxgbe/cxgbei/cxgbei.c
@@ -592,7 +592,6 @@ do_rx_iscsi_cmp(struct sge_iq *iq, const struct rss_header *rss, struct mbuf *m)
 	} else {
 		MPASS(icp->icp_flags & (ICPF_RX_FLBUF));
 		MPASS(ip->ip_data_len == ip->ip_data_mbuf->m_pkthdr.len);
-		MPASS(icp->icp_seq == tp->rcv_nxt);
 	}
 
 	tp->rcv_nxt = icp->icp_seq + pdu_len;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202110292358.19TNwN4v003701>