From owner-svn-src-head@freebsd.org Wed Jul 29 02:22:39 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E1679AD65A; Wed, 29 Jul 2015 02:22:39 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-ob0-x235.google.com (mail-ob0-x235.google.com [IPv6:2607:f8b0:4003:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C74F93E4; Wed, 29 Jul 2015 02:22:38 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by obnw1 with SMTP id w1so98503097obn.3; Tue, 28 Jul 2015 19:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=7ZbJr2s013wgEaBa/o2vm3gTh65/uFid+hfl/5za/io=; b=NaN6kjo1wpaDNBv0E3y5r8vykJXYqVcQN6kK293EMvaicDN+6RTFwoDiCe5Ndk5QUV 5JObWkWxjDfJ7v7exr92zYI1wRnLhveowSvMtZlPZ+ZjJA+58hJwiU+Rx5CEiOHWI4u6 jL/NZLMTMNkM83M5RZTU7olZ6Fxgg/zjzl6ezvc6uLsH5QABGCPrg/s7ftQQVtNtKB97 uXCl8edr91+pb4MQ7v9gfLXv1AI4WgWlXpkOu25McP/BpmprIcLvalyYFiTB45Z9k5mS yOAJbx2HvzAPhE7pIl8iA986sYh9VF7bPCOZZsCbPmtF4epsfnjtJRpuPADx5CVj2ZuY MjNg== MIME-Version: 1.0 X-Received: by 10.60.80.229 with SMTP id u5mr39155343oex.27.1438136558073; Tue, 28 Jul 2015 19:22:38 -0700 (PDT) Received: by 10.202.11.193 with HTTP; Tue, 28 Jul 2015 19:22:38 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <201507280232.t6S2WfSq043383@repo.freebsd.org> Date: Wed, 29 Jul 2015 10:22:38 +0800 Message-ID: Subject: Re: svn commit: r285926 - in head: libexec/ypxfr usr.bin/ypcat usr.bin/ypmatch usr.bin/ypwhich usr.sbin/yp_mkdb usr.sbin/yppush usr.sbin/ypserv From: Marcelo Araujo To: Ed Schouten Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 02:22:39 -0000 Hello Ed, Fixed, thank you very much. https://svnweb.freebsd.org/base?view=revision&revision=285992 Best, 2015-07-28 15:05 GMT+08:00 Ed Schouten : > Hi Marcelo, > > Thanks for working on this! > > 2015-07-28 4:32 GMT+02:00 Marcelo Araujo : > > -struct ypalias { > > +const struct ypalias { > > char *alias, *name; > > -} ypaliases[] = { > > +} static ypaliases[] = { > > { "passwd", "passwd.byname" }, > > { "master.passwd", "master.passwd.byname" }, > > { "shadow", "shadow.byname" }, > > I seem to remember that certain compilers (Intel?) are pretty picky > about the ordering of 'static' and 'const'. > > const static int i; // Compiler error. > > It's also inconsistent with the rest of our codebase, where we > typically put 'static' in front of the type. Could you please change > this to the following? > > static const struct ypalias { > ... > } ypaliases[] = { > ... > }; > > Thanks! > > -- > Ed Schouten > Nuxi, 's-Hertogenbosch, the Netherlands > KvK/VAT number: 62051717 > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)