From owner-freebsd-current Sun Jun 23 14:16:44 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id OAA22954 for current-outgoing; Sun, 23 Jun 1996 14:16:44 -0700 (PDT) Received: from sequent.kiae.su (sequent.kiae.su [193.125.152.6]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id OAA22946; Sun, 23 Jun 1996 14:16:25 -0700 (PDT) Received: by sequent.kiae.su id AA14228 (5.65.kiae-2 ); Mon, 24 Jun 1996 01:09:22 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Mon, 24 Jun 96 01:09:21 +0400 Received: (from ache@localhost) by nagual.ru (8.7.5/8.7.3) id BAA00333; Mon, 24 Jun 1996 01:07:55 +0400 (MSD) Message-Id: <199606232107.BAA00333@nagual.ru> Subject: Re: Syscons mouse as entropy source. Please review... To: mark@grondar.za (Mark Murray) Date: Mon, 24 Jun 1996 01:07:54 +0400 (MSD) Cc: bde@FreeBSD.org, sos@FreeBSD.org, current@FreeBSD.org In-Reply-To: <199606231613.SAA01694@grumble.grondar.za> from "Mark Murray" at "Jun 23, 96 06:13:04 pm" From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (Andrey A. Chernov) X-Class: Fast X-Mailer: ELM [version 2.4ME+ PL22 (25)] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > SYSCONS's new mouse driver is a _Great_ source of entropy. Please > comment on/review these diffs. I am mostly concerned with the > placement of the add_mouse_randomness() call, as I do not want > to slow down the mouse cursor more than is necessary... 1) You need to check somewhere, that mouse cursor REALLY RUNNING, or you always got 0,0 2) You can use mouse pointer info ONLY IF PREVIOUS X,Y VALUES != CURRENT values. I can never touch my mouse for hours! -- Andrey A. Chernov http://www.nagual.ru/~ache/