Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Mar 2020 15:06:10 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Ed Maste <emaste@freebsd.org>
Cc:        =?UTF-8?Q?Ulrich_Sp=C3=B6rlein?= <uspoerlein@gmail.com>, git@freebsd.org
Subject:   Re: Strange commit
Message-ID:  <CANCZdfo1d5dLkbAAnOVYLOPwbdP-FyTMJ7T%2BDYvzabYr0vfQ8g@mail.gmail.com>
In-Reply-To: <CAPyFy2BcEgpuK3JDa6AUGsoGxwKmY1ozk-HqRNarvQMGtXFpwg@mail.gmail.com>
References:  <CANCZdfrRuLf6Q3Q-XzDe5wpSV3XCvkhht2ESh=bXbL6wAtt87g@mail.gmail.com> <CAPyFy2Dm12BD4yuGo65T_tQrGXapZxvSSurO=Gwn=2S1drq6ig@mail.gmail.com> <CAJ9axoRs9zWXteeDmZ8L1nucBPqqB-WMGuXTRFyVuxo2h4F11w@mail.gmail.com> <CAPyFy2BgeP=WxeZeYVS3z%2BgzArJe1h9ofO42O7HvznpLBsBKbg@mail.gmail.com> <CANCZdfo8m4Kg%2BXTbUJYwi1gxOr8C9RobBR0DcZ6D6veiKkOB2Q@mail.gmail.com> <CAPyFy2DROg_v47QrxmK-1TuFzqTqf=2e63N7qoX1_V=GyDkyRg@mail.gmail.com> <CANCZdfpoROXZOn0CdX6w=TK03FWc-f8sR9XJQ4cxb_Mq9GBUqw@mail.gmail.com> <CAPyFy2BcEgpuK3JDa6AUGsoGxwKmY1ozk-HqRNarvQMGtXFpwg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 27, 2020, 1:30 PM Ed Maste <emaste@freebsd.org> wrote:

> On Fri, 27 Mar 2020 at 15:12, Warner Losh <imp@bsdimp.com> wrote:
> >
> > The vendor repos we wanted to do would be complete on their own. We
> don't want the revisions of those repos in the main repo. A merge commit
> would make us have them in the main repo. Then again, maybe this eliminates
> subt free if we can't do that. It was why we were looking at the other one:
> it creates a repo that is independent of the merged in repo and it requires
> no extra modules for our users to install.
>
> We do want revisions of the contrib code in the main repo, otherwise
> we lose the history and the ability to easily maintain our local
> changes.
>

I'm sorry, that's a *HUGE* change from what we decided. And it doesn't lose
the ability for us to maintain our own local changes easily...

We decided, specifically that we'd export the vendor branches, vis git
subtree, to their own repos that would live under our github. We'd then use
git subrepo to them pull in the changes into src/contrib, et al, as a
single commit with tracking information. This would keep us from being the
union of all possible upstream repos (think llvm). We'd have sufficient
tracking info to know the history, but it might be a little awkward to pull
it all out since you'd need to download the extra repo and install git
subrepo. In that scenario, they most definitely aren't merge commits in the
classic sense (logically they are, and subrepo records enough details... we
thought subtree might also do it too, but that was a point that was
supposed to be investigated, but I'm not sure if that detail has been). We
were also, IIRC (and I may not), going to bootstrap the vendor branches so
any of them could be used to update from the get-go in the new git repo so
we wouldn't need the 'vendor branch collapsing' stuff from svn, because
we'd have already done it in svn prior to the export and because the
exported repos would be sufficient.

Maybe we should chat about this stuff again, but I have a very very clear
memory of all of this, and thought it was a good plan despite some initial
misgivings.

Warner

>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo1d5dLkbAAnOVYLOPwbdP-FyTMJ7T%2BDYvzabYr0vfQ8g>