From owner-freebsd-ports@freebsd.org Tue Nov 24 08:51:14 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2DFEA47DE0B for ; Tue, 24 Nov 2020 08:51:14 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from gmailer.gwdg.de (gmailer.gwdg.de [134.76.11.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CgHmx2b0wz4RL4 for ; Tue, 24 Nov 2020 08:51:13 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from excmbx-03.um.gwdg.de ([134.76.9.218] helo=email.gwdg.de) by mailer.gwdg.de with esmtp (GWDG Mailer) (envelope-from ) id 1khU2Z-0004px-Ip for freebsd-ports@FreeBSD.org; Tue, 24 Nov 2020 09:51:11 +0100 Received: from pc028.nfv.nw-fva.de (10.250.9.199) by EXCMBX-03.um.gwdg.de (134.76.9.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2044.4; Tue, 24 Nov 2020 09:51:11 +0100 To: From: Rainer Hurling Subject: Portlint complains about %%FOO%% in PLIST_FILES Reply-To: Message-ID: <50337e9b-ab50-6877-a5a6-213006f2195e@gwdg.de> Date: Tue, 24 Nov 2020 09:51:11 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.250.9.199] X-ClientProxiedBy: excmbx-22.um.gwdg.de (134.76.9.232) To EXCMBX-03.um.gwdg.de (134.76.9.218) X-Virus-Scanned: (clean) by clamav X-Rspamd-Queue-Id: 4CgHmx2b0wz4RL4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rhurlin@gwdg.de designates 134.76.11.17 as permitted sender) smtp.mailfrom=rhurlin@gwdg.de X-Spamd-Result: default: False [-2.78 / 15.00]; HAS_REPLYTO(0.00)[rhurlin@FreeBSD.org]; ARC_NA(0.00)[]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[134.76.11.17:from]; FREEFALL_USER(0.00)[rhurlin]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[gwdg.de]; R_SPF_ALLOW(-0.20)[+ip4:134.76.10.0/23]; RCVD_IN_DNSWL_MED(-0.20)[134.76.11.17:from]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_SHORT(-0.28)[-0.282]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:680, ipnet:134.76.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-ports] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 08:51:14 -0000 Yesterday I committed net/hblock [r556099] after changing the patch to PLIST_FILES (instead of pkg-plist with only two files) against the suggestion of the submitter.The line in question is: PLIST_FILES=bin/${PORTNAME} %%MANPAGES%%man/man1/hblock.1.gz I made this change because it allows the port to build and install correctly in all combinations of OPTIONS. With the use of %%MANPAGES%%% in PLIST_FILES one can selectively enable and disable the building of manpages. The maintainer of net/hblock informs me about a problem with using %%MANPAGES%% in PLIST_FILES. I don't know why I did not notice the message from 'portlint -AC' before: FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead Is it possibly correct to use %%MANPAGES%% in PLIST_FILES and only portlint can't handle it? Is there an alternative to switching back to pkg-plist file? Thanks in advance for clarification and maybe a suggestion for correct usage. Regards, Rainer Hurling