Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Sep 2003 02:05:58 +0200 (CEST)
From:      Simon Barner <barner@in.tum.de>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        gnome@FreeBSD.org
Subject:   [patch] x11-fm/nautilus2: fix crash with unknown protocols
Message-ID:  <20030922000558.642673B445@zi025.glhnet.mhn.de>

next in thread | raw e-mail | index | archive | help

>Submitter-Id:	current-users
>Originator:	Simon Barner
>Organization:	
>Confidential:	no 
>Synopsis:	[patch] x11-fm/nautilus2: fix crash with unknown protocols
>Severity:	serious
>Priority:	medium
>Category:	ports
>Class:		change-request
>Release:	FreeBSD 4.9-PRERELEASE i386
>Environment:
System: FreeBSD zi025.glhnet.mhn.de 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #1: Thu Sep 4 20:49:53 CEST 2003 simon@zi025.glhnet.mhn.de:/usr/src/sys/compile/KISTE i386

>Description:

When you enter an unknown protocol in Nautilus 2, it will crash. This bug
has already been reported to bugzilla.gnome.org, and it has been fixed
in the CVS version of Nautilus:

http://bugzilla.gnome.org/show_bug.cgi?id=122265
http://cvs.gnome.org/bonsai/cvsview2.cgi?command=DIFF&subdir=nautilus%2Flibnautilus-private&file=nautilus-file.c&rev1=1.327&rev2=1.328&whitespace_mode=show&diff_mode=context

I would suggest to include this tiny patch to the Nautilus 2 port in
order to fix the problem until the next release.

>How-To-Repeat:

Enter an invalid location, such as `foobar:///', and Nautilus 2.4.0 will
crash.

>Fix:

This patch implements the fix from the Nautilus CVS repository (maybe
you also want to bump the port version?).

diff -ruN nautilus2.orig/files/patch-libnautilus-private::nautilus-file.c nautilus2/files/patch-libnautilus-private::nautilus-file.c
--- nautilus2.orig/files/patch-libnautilus-private::nautilus-file.c	Thu Jan  1 01:00:00 1970
+++ nautilus2/files/patch-libnautilus-private::nautilus-file.c	Sun Sep 21 22:19:14 2003
@@ -0,0 +1,11 @@
+--- libnautilus-private/nautilus-file.c.orig	Sun Sep 21 22:14:27 2003
++++ libnautilus-private/nautilus-file.c	Sun Sep 21 22:15:32 2003
+@@ -357,8 +357,6 @@
+ 				relative_uri_tmp++;
+ 			}
+ 			relative_uri = strdup (relative_uri_tmp);
+-		} else {
+-			g_assert_not_reached ();
+ 		}
+ 	}
+ 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030922000558.642673B445>