From owner-svn-src-head@freebsd.org Fri Dec 28 19:08:51 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37863141F304; Fri, 28 Dec 2018 19:08:51 +0000 (UTC) (envelope-from crees@freebsd.org) Received: from mail56c50.megamailservers.eu (mail168c50.megamailservers.eu [91.136.10.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6EFF396366; Fri, 28 Dec 2018 19:08:50 +0000 (UTC) (envelope-from crees@freebsd.org) X-Authenticated-User: bayofrum@uwclub.net Received: from pegasus.bayofrum.net (host-80-41-58-105.as13285.net [80.41.58.105]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id wBSJ8kSj013950; Fri, 28 Dec 2018 19:08:47 +0000 Received: from android-4497c5999ce4d9aa.bayofrum.net (android-4497c5999ce4d9aa.bayofrum.net [192.168.1.115]) by pegasus.bayofrum.net (Postfix) with ESMTPSA id 7F1F6A308; Fri, 28 Dec 2018 19:08:41 +0000 (GMT) Date: Fri, 28 Dec 2018 19:08:38 +0000 User-Agent: K-9 Mail for Android In-Reply-To: References: <201812241047.wBOAlmwc092761@repo.freebsd.org> <1c2d5b66-42f2-63e6-9f62-aa383e9b79b9@freebsd.org> <5766D4AE-C093-4B48-9570-E4FC84E63CF2@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=crees@FreeBSD.org; keydata= mQENBFA55DwBCADLmiSSORwcGwNoCi2X02jPmS2lcZXWp5uCtzx0ybPM65tIQAIIL5e8QzyrV+r/ yyNdGJIKtl4ty69aVodQ6n6Xf2BGqmm/x6jlvg2BrJgNHYfAjkIVtugkbwsMQxHkNmOlB+fURVPJ k9xub4pz9kRRdtXJ3DiImQRw5XVe2ZvBXZuu2nOzjw2zArEaBSLbjo1MlXWJvvuyA2ktaKcAjFyf z/VJ8M/RDbJdfYDB9Q78jrr4uwIMlyWSWUD8RxAvbWw0My2tr1Nu9FDvsydbKygGnZ+7oo4zvqnc GZ+0am6D3XSsOcaf/bzB8pIGJ1hsSe9JHvYpLvnWCwP+AJtKTPwFABEBAAG0HkNocmlzIFJlZXMg PGNyZWVzQEZyZWVCU0Qub3JnPokBOAQTAQIAIgUCUDnkPAIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AACgkQkA9Fph4S6WoK/gf/eghgBaGoxfXXbNZwZNIC0NUhISasXVYnKNpKCojFl80ZGzI5 mPAFUiQm6aMh3fSrzTIB1uxxd9T9A3KN5ghf9jjtOmpU+uYEm1aW4wHYSWzKDfgfV3QlFOROBn02 V8xc1XPaZr0pqBCSJ18BDVwsI8UG9odw/vPrrcE/Gm3psKJRwaHVGTtvJYPZYB5dQM5XD0shvj7D DSdut5l7DGDGUhp6Q8R32iMkCSTbaJEQNMzUqoIIw/oPrgsVeNxG7zFrkxbdl4YLmuzy9nZhRPLZ 7lWpoRrf3lsvo7WktMEXiW+uAX23wKH3P0gSypcsJ/jbb0nfV1r13/8O8plXwo5Z9LACAAC5AQ0E VPxUlAEIALN/EYmN7OVxEUwJXAgu0xjeAAmd4p8Q0UTX0d7cQCUFo1xltQP3JaITxzAJSFbpSuAV 2b+27Ly6xmLbloJp9bgutqGSW/yWd7UNrxULA77WmSnX6rcgvRXfL75ZMg5JQ04Qffp66IM/NSAo 7rQqDOKgVTHvAomP9AORQKB8vsgSiYRPEMJrkUJH6dXVmRCNKJE27SnM2WDZ1FByQhaWQcIUTCXA FKw89W5PwF10GpIf8JDxlV1gGRyGUuPKjYqCencFvpSZF0PISdSoINDey2D3g5K8epcwIhpfO2Y9 Qti5pzSc9G+2CmFN7oihOhDsIW8WodsBGmJgyRrdzu/woZ8AEQEAAYkBJQQYAQIADwUCVPxUlAIb DAUJCWYBgAAKCRCQD0WmHhLpatS6B/9T7y/L1XRyqopmq3n2Wx05qWZEh6mSqw/BxiunwL7OK9TJ OrxIykpkrcmKGElNKFUJpcLFLGJE+wid6ys0c1EvyQnmp3OPSpaiE+YdRR9xPRCtLUF1ibp2CeKW LOLs6WN+tURAE0GLCqX8K5OyeRvAD2j3aJLcmZbcOFDUEK3Gq00X8bx4kw4LxRW0l/DZdYj/TMoF Ub1FzrdvIvw9L7gbso5xwA1N5YXN8GCIRAg0hIV5t1prFcfx+q2JhijP+vYc3UIjTvpTo+F1KBnI A9NHLxTtREKsGPEuErGG46eyvZ7THl44SkdxWrwvs7Wal6qy7qxz59OOAuu0f0T3ZtHq Subject: Re: svn commit: r342389 - head/share/man/man5 To: Niclas Zeising , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Chris Rees Message-ID: <9956BAC0-1CBC-47C5-BFAF-85931CC94201@FreeBSD.org> X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: 7F1F6A308.A75C5 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@freebsd.org X-Spam-Status: No X-CTCH-RefID: str=0001.0A0B0214.5C2674C0.002A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Oo5hNR3t c=1 sm=1 tr=0 a=EuuEpbt/dLJjUk3psnl2FQ==:117 a=EuuEpbt/dLJjUk3psnl2FQ==:17 a=IkcTkHD0fZMA:10 a=2ur7OfE09M0A:10 a=6I5d2MoRAAAA:8 a=rjS4v_Ixg7xyYl4jwVMA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 X-Rspamd-Queue-Id: 6EFF396366 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 19:08:51 -0000 On 28 December 2018 19:02:14 GMT+00:00, Niclas Zeising wrote: >On 12/28/18 7:43 PM, Chris Rees wrote: >> Hey, >>=20 >> On 28 December 2018 18:19:57 GMT+00:00, Niclas Zeising > wrote: >>> On 12/24/18 11:47 AM, Chris Rees wrote: >>>> Author: crees (doc,ports committer) >>>> Date: Mon Dec 24 10:47:48 2018 >>>> New Revision: 342389 >>>> URL: https://svnweb.freebsd.org/changeset/base/342389 >>>> >>>> Log: >>>> Clarify kld_list format >>>>=20=20=20=20=20 >>>> PR: docs/234248 >>>> Submitted by: David Fiander >>>> Submitted by: Miroslav Lachman >>>> >>>> Modified: >>>> head/share/man/man5/rc.conf.5 >>>> >>>> Modified: head/share/man/man5/rc.conf.5 >>>> >>> >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >>>> --- head/share/man/man5/rc.conf.5 Mon Dec 24 06:14:32 >2018 (r342388) >>>> +++ head/share/man/man5/rc.conf.5 Mon Dec 24 10:47:48 >2018 (r342389) >>>> @@ -248,12 +248,14 @@ Default >>>> .Pa /etc/ddb.conf . >>>> .It Va kld_list >>>> .Pq Vt str >>>> -A list of kernel modules to load right after the local >>>> -disks are mounted. >>>> +A whitespace-separated list of kernel modules to load right after >>>> +the local disks are mounted, without any >>>> +.Pa .ko >>>> +extension or path. >>>> Loading modules at this point in the boot process is >>>> much faster than doing it via >>>> .Pa /boot/loader.conf >>>> -for those modules not necessary for mounting local disk. >>>> +for those modules not necessary for mounting local disks. >>>> .It Va kldxref_enable >>>> .Pq Vt bool >>>> Set to >>> >>> >>> Hi! >>> Sorry for jumping into this so late. >>> Please please PLEASE don't break loading modules by path in >kld_list. >>> This is used by the drm-kmod files to distinguish them from the base >>> modules, and this has been communicated in documentation all over >the >>> place, including numerous ports. >>> >>> Can this please be reverted, or amended to match reality. >>> >>> In practice, adding both the path and the extension (.ko) to a >module >>> in >>> kld_list works and the module loads. >>=20 >> As the code itself stands, it works for loading, but throws an error >if you try to load an already loaded module adding a .ko extension. In >other words, it works but is wrong. The path actually still does work, >which was my mistake. >>=20 >> I'm awaiting approval for this, which correctly handles all cases: >>=20 >> https://reviews.freebsd.org/D18670 >>=20 >> Konstantin has reviewed, but doesn't feel comfortable giving approval >as it's not his area, which is fair enough. >>=20 >> Chris >>=20 > >Ok. >Will this continue to work when loading /path/to/foo.ko rather than=20 >path/to/foo? (I assume it will) >Regards Unlike now, it will work correctly, including if the module is already load= ed. Chris --=20 This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.