From owner-freebsd-ipfw@FreeBSD.ORG Fri Nov 7 12:51:51 2003 Return-Path: Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D7F416A4CE for ; Fri, 7 Nov 2003 12:51:51 -0800 (PST) Received: from cheer.mahoroba.org (flets19-018.kamome.or.jp [218.45.19.18]) by mx1.FreeBSD.org (Postfix) with ESMTP id B05C743F85 for ; Fri, 7 Nov 2003 12:51:49 -0800 (PST) (envelope-from ume@mahoroba.org) Received: from lyrics.mahoroba.org (IDENT:tlXxe6V2RmZUIRelpCj6xd2G1ygc7cDjwULE/fbree4EY1Evv78DeITy7ZGkQ/g9@lyrics.mahoroba.org [IPv6:3ffe:501:185b:8010:280:88ff:fe03:4841]) (user=ume mech=CRAM-MD5 bits=0)hA7KotEU009017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 8 Nov 2003 05:50:58 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Sat, 08 Nov 2003 05:50:55 +0900 Message-ID: From: Hajimu UMEMOTO To: "Bjoern A. Zeeb" In-Reply-To: References: <001501c3a524$8bc40170$0235a8c0@raisa> User-Agent: xcite1.38> Wanderlust/2.11.3 (Wonderwall) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 5.1-CURRENT MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on cheer.mahoroba.org cc: Luigi Rizzo cc: Hajimu UMEMOTO cc: freebsd-ipfw@freebsd.org Subject: Re: HEAD ip_fw2 ipsec b0rked X-BeenThere: freebsd-ipfw@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: IPFW Technical Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2003 20:51:51 -0000 Hi, >>>>> On Fri, 7 Nov 2003 12:26:12 +0000 (UTC) >>>>> "Bjoern A. Zeeb" said: bzeeb-lists> Either removing the f() entirely will make people notice it at compile bzeeb-lists> time that s.th. is missing bzeeb-lists> or running a find over the src tree will let you find these functions bzeeb-lists> but giving a panic() isn't that nice ;-)) I've just committed to nuke obsoleted ipsec_gethist(). However, since opt_ipsec.h is not included, IPsec code is not compiled in. So, it cannot detect this case. ;) bzeeb-lists> Perhaps Luigi or you culd review my patch and commit it so that both bzeeb-lists> problems get fixed at ones because fixing one will not help making the bzeeb-lists> other work in ip_fw2.c. Since I dunno if it is intentional or not that it doesn't activate IPsec code, I didn't change to include opt_ipsec.h. I believe best person is Luigi. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/