From owner-freebsd-threads@FreeBSD.ORG  Sat Sep 16 21:00:53 2006
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
X-Original-To: freebsd-threads@hub.freebsd.org
Delivered-To: freebsd-threads@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4168816A4A7
	for <freebsd-threads@hub.freebsd.org>;
	Sat, 16 Sep 2006 21:00:53 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C494843D55
	for <freebsd-threads@hub.freebsd.org>;
	Sat, 16 Sep 2006 21:00:52 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k8GL0qRr032127
	for <freebsd-threads@freefall.freebsd.org>;
	Sat, 16 Sep 2006 21:00:52 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k8GL0q29032125;
	Sat, 16 Sep 2006 21:00:52 GMT (envelope-from gnats)
Date: Sat, 16 Sep 2006 21:00:52 GMT
Message-Id: <200609162100.k8GL0q29032125@freefall.freebsd.org>
To: freebsd-threads@FreeBSD.org
From: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
Cc: 
Subject: Re: threads/103127: Kernel panic while using thread features in
	Squid 2.6
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Sep 2006 21:00:53 -0000

The following reply was made to PR kern/103127; it has been noted by GNATS.

From: John-Mark Gurney <gurney_j@resnet.uoregon.edu>
To: Anders Nordby <anders@fupp.net>
Cc: FreeBSD-gnats-submit@FreeBSD.org, freebsd-threads@FreeBSD.org,
        Thomas-Martin Seck <tmseck@netcologne.de>,
        Suleiman Souhlal <ssouhlal@FreeBSD.org>
Subject: Re: threads/103127: Kernel panic while using thread features in Squid 2.6
Date: Sat, 16 Sep 2006 13:59:08 -0700

 --oC1+HKm2/end4ao3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 Anders Nordby wrote this message on Wed, Sep 13, 2006 at 20:58 +0200:
 > After talking with Pawel, I tried the attached patch to get some kqueue
 > debug info. I just got it:
 > 
 > Sep 13 20:18:56 cache3 kernel: NULL f_event in new kn
 > Sep 13 20:18:56 cache3 kernel: f_event == NULL
 > 
 > Then Squid stops responding to new requests, and I can not even kill it
 > with kill -9:
 
 Please try the attached patch.. It appears that the badfo_kqfilter was
 returning sucess instead of error since it was introcuded many years
 ago...  This many still cause other problems w/ squid, but will fix
 the panics...
 
 -- 
   John-Mark Gurney				Voice: +1 415 225 5579
 
      "All that I will do, has been done, All that I have, has not."
 
 --oC1+HKm2/end4ao3
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="badfo_kqfilter.patch"
 
 Index: kern_descrip.c
 ===================================================================
 RCS file: /home/ncvs/src/sys/kern/kern_descrip.c,v
 retrieving revision 1.297
 diff -u -r1.297 kern_descrip.c
 --- kern_descrip.c	21 Jul 2006 20:24:00 -0000	1.297
 +++ kern_descrip.c	16 Sep 2006 20:58:40 -0000
 @@ -2632,7 +2632,7 @@
  badfo_kqfilter(struct file *fp, struct knote *kn)
  {
  
 -	return (0);
 +	return (EINVAL);
  }
  
  static int
 
 --oC1+HKm2/end4ao3--