Date: Fri, 12 Oct 2007 14:10:43 -0700 From: "Maksim Yevmenkin" <maksim.yevmenkin@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc/defaults rc.conf src/etc/rc.d ppp Message-ID: <bb4a86c70710121410g7600d883u5bceb9b947ce1533@mail.gmail.com> In-Reply-To: <20071012200336.H6043@maildrop.int.zabbadoz.net> References: <200710121635.l9CGZbO2063862@repoman.freebsd.org> <20071012200336.H6043@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/12/07, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote: > On Fri, 12 Oct 2007, Maksim Yevmenkin wrote: > > > emax 2007-10-12 16:35:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > etc/defaults rc.conf > > etc/rc.d ppp > > Log: > > Teach /etc/rc.d/ppp to start multiple instances of ppp. > > > > ppp_profile variable can now contain multiple profiles. > > Overrides for ppp mode and nat can go into ppp_$profile_mode > > and ppp_$profile_nat variables respectively. If those are > > not specified, defaults from ppp_mode and ppp_nat are used. > > > > Submitted by: Yuri Kurenkov < y dot kurenkov at init dot ru > > > Reviewed by: mtm > > MFC after: 1 week > > > > Revision Changes Path > > 1.319 +6 -0 src/etc/defaults/rc.conf > > 1.14 +43 -9 src/etc/rc.d/ppp > > I wonder how that differs from the script proposed in > http://www.freebsd.org/cgi/query-pr.cgi?pr=114081 it does look similar :) i was not aware of your patch (and it is not clear from from the pr title that one should look there for similar patch :) in fact, it took me good ten minutes to find it. > which should also provide a fallback to the global > setting in case the _profile on is not given... the version i have committed provides fallback to default ppp_mode and ppp_nat if profile specific mode and nat overrides were omitted. you also deserve the credit for your work. thanks, max
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c70710121410g7600d883u5bceb9b947ce1533>