Date: Fri, 01 Nov 2013 01:54:24 +0100 From: John Marino <freebsd.contact@marino.st> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, "Jason E. Hale" <jhale@freebsd.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r332099 - head/devel/cssc/files Message-ID: <5272FBC0.2050306@marino.st> In-Reply-To: <5271A160.8050309@marino.st> References: <201310301246.r9UCkiWu069471@svn.freebsd.org> <52710244.3040708@marino.st> <2602741.QmfnMIAQrR@mocha.verizon.net> <5271A160.8050309@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/31/2013 01:16, John Marino wrote: > On 10/31/2013 00:23, Jason E. Hale wrote: >> Sorry, I guess my working copy was a little out of sync. The patch submitted >> by the maintainer does ultimately include <unistd.h>. I ran build tests >> before committing it, so I can confirm that it works. If you don't mind, I'll >> just delete your patch so we don't have two patches for the same file. > > A lot of these tests are flawed I've found (false passes). However, if > the maintainer patch contains <unistd.h>, I'm happy. Feel free to > remove the patch I added. > Well, the maintainer patch does NOT contain <unistd.h>, contrary to what you said earlier so now it's broken again with gcc47+. Can you please retrieve the contents of my patch and integrate it into the maintainer patch? Thanks, John http://svnweb.freebsd.org/ports/head/devel/cssc/files/patch-unit-tests__googletest__include__gtest__internal__gtest-port.h?revision=332099&view=markup
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5272FBC0.2050306>