From owner-svn-ports-head@freebsd.org Sun Oct 28 13:32:02 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3B9410D0CCA; Sun, 28 Oct 2018 13:32:02 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: from mail-it1-x12e.google.com (mail-it1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 33CD78467F; Sun, 28 Oct 2018 13:32:02 +0000 (UTC) (envelope-from bacon4000@gmail.com) Received: by mail-it1-x12e.google.com with SMTP id y123-v6so315109itc.1; Sun, 28 Oct 2018 06:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=AL9Xg4m+zREs1NyPzNGVuHWwq2NkjeePdiEz8f2/7iY=; b=FY57fwbs3dz1DmsKUVk+D8Fw5kltQyk0dfcMVdsivnhDXzuscjLxSxw+cvVvAsJR57 +/W8dd4e2C0x/0oONfcb+z1CZ4EjTwJUkxEqYIr+nni7spFc4xyErIrmBO67Y1TNd295 mVGWNgQL/p3kbPsZGPW/M1eIFy7NhLkfLCcy06EizBVH2owuOmjSFf1mg65wc5Ga7s5a StEDQKhsNL4ZQpYbPyMXhY8C58v14SjjCLFCR73P+lLsgnCaQ4tRcHEh/n3K83xGBNZW WhxsAycl3OTJT2z0VPG4I9gVmbkuclvgXdIg6xZ5XKdqKcl1JnXmakIJYlFszkCG2K0C C28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=AL9Xg4m+zREs1NyPzNGVuHWwq2NkjeePdiEz8f2/7iY=; b=fFsqASHCVMbq37r8Yr1n46pbEp3OC7ULXqEnokefBIXNXXPv/Zf8ZW1XUEYwppYORD gfDSnpUC27QgFL7GLLYuuTyrFX1DvOwL4y0uyBC6q8PuUBRyk6zYTXAr8jMSw5x4tToH ATtB36IdQv1shA7nSwEcotM+ndeOw31EGQgUQgpuHBatBYZEOlcqzkbvHny6ejqH6psG G8rAZoAmqtzfWOar16L9u4x/MuNewQtvo6TqC6JweHMLAue+xdgrkxlLbHzIVjIXAkRK 1aEkVig3vCf2OglPbX5UKXF//jtsbkl+bolyoXccYu0oZPY7Bo6oTzDT1HGTDFYCDL+h BaNA== X-Gm-Message-State: AGRZ1gJDfmWwBtIa5J1g/Ie1JHRKGf7ubPcVjfsNv9/gIfUmAuRe/Y68 KO3xeC8y5EuNWjqrTCFRLbG7R4Os X-Google-Smtp-Source: AJdET5crOMonp0Odp0UaM2DbkU6OeoZVOewPZ9jSJULpOolc27Nblc1Q8Y6mAyGsxTisUFhiDfwi1w== X-Received: by 2002:a24:a949:: with SMTP id x9-v6mr7602982iti.67.1540733521217; Sun, 28 Oct 2018 06:32:01 -0700 (PDT) Received: from cray.acadix.biz (cpe-174-102-163-140.wi.res.rr.com. [174.102.163.140]) by smtp.gmail.com with ESMTPSA id x21-v6sm4988891ita.6.2018.10.28.06.31.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Oct 2018 06:32:00 -0700 (PDT) Subject: Re: svn commit: r483245 - head/biology/stacks To: Jan Beich , Mark Linimon Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201810280858.w9S8w0sk015320@repo.freebsd.org> <5zxm-1d6y-wny@FreeBSD.org> From: Jason Bacon Message-ID: Date: Sun, 28 Oct 2018 08:31:58 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <5zxm-1d6y-wny@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 13:32:02 -0000 Looks reasonable to me and works on amd64.  In cases like this I would add a comment # Also requires openmp USES=           compiler:gcc-c++11-lib gmake python shebangfix to document why we're using gcc. On 10/28/18 7:13 AM, Jan Beich wrote: > Mark Linimon writes: > >> Author: linimon >> Date: Sun Oct 28 08:58:00 2018 >> New Revision: 483245 >> URL: https://svnweb.freebsd.org/changeset/ports/483245 >> >> Log: >> Fix build with tier-2 arches. >> >> PR: 231448 >> Submitted by: Piotr Kubaj >> Approved by: maintainer >> >> Modified: >> head/biology/stacks/Makefile >> >> Modified: head/biology/stacks/Makefile >> ============================================================================== >> --- head/biology/stacks/Makefile Sun Oct 28 08:56:24 2018 (r483244) >> +++ head/biology/stacks/Makefile Sun Oct 28 08:58:00 2018 (r483245) >> @@ -18,4 +18,10 @@ GNU_CONFIGURE= yes >> >> LDFLAGS+= -lpthread >> >> -.include >> +.include >> + >> +.if ${ARCH} != amd64 && ${ARCH} != i386 >> +USE_GCC= yes >> +.endif >> + >> +.include > Why not USES=compiler:gcc-c++11-lib ? > -- Earth is a beta site.