Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 14 Jan 2009 07:06:28 GMT
From:      Weongyo Jeong <weongyo@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 156139 for review
Message-ID:  <200901140706.n0E76SwT095713@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=156139

Change 156139 by weongyo@weongyo_ws on 2009/01/14 07:05:52

	fix a ehci's bug that it's occurred when the xfers are aborted under
	heavy loads or working.  It looks this bug exists since r158869 so
	needs to revert a part of the previous.
	
	This helps some panics related with aborting the xfers of ehci(4).
	
	Reviewed by:	imp
	Tested by:	sam

Affected files ...

.. //depot/projects/vap/sys/dev/usb/ehci.c#18 edit

Differences ...

==== //depot/projects/vap/sys/dev/usb/ehci.c#18 (text+ko) ====

@@ -2753,7 +2753,7 @@
 
 	/* We will change them to point here */
 	snext = exfer->sqtdend->nextqtd;
-	next = htohc32(sc, snext->physaddr);
+	next = (snext != NULL) ? htohc32(sc, snext->physaddr) : EHCI_NULL(sc);
 
 	/*
 	 * Now loop through any qTDs before us and keep track of the pointer



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901140706.n0E76SwT095713>