Skip site navigation (1)Skip section navigation (2) 
Date:      Thu, 20 Jul 2017 16:24:29 +0000 (UTC)
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r321295 - in head/lib: libc/sys librt
Message-ID:  <201707201624.v6KGOTme014885@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: asomers
Date: Thu Jul 20 16:24:29 2017
New Revision: 321295
URL: https://svnweb.freebsd.org/changeset/base/321295

Log:
  Remove some private symbols from librt
  
  Private functions like __aio_read and _aio_read were exposed in
  FBSDprivate_1.0 by r169090, even though they've never been used outside of
  librt. Also, remove some weak references from r156136 that have never
  resolved.
  
  Reviewed by:	kib
  MFC after:	3 weeks
  Sponsored by:	Spectra Logic Corp
  Differential Revision:	https://reviews.freebsd.org/D11649

Modified:
  head/lib/libc/sys/Symbol.map
  head/lib/librt/Symbol.map
  head/lib/librt/aio.c

Modified: head/lib/libc/sys/Symbol.map
==============================================================================
--- head/lib/libc/sys/Symbol.map	Thu Jul 20 15:52:36 2017	(r321294)
+++ head/lib/libc/sys/Symbol.map	Thu Jul 20 16:24:29 2017	(r321295)
@@ -469,21 +469,13 @@ FBSDprivate_1.0 {
 	__sys_acct;
 	_adjtime;
 	__sys_adjtime;
-	_aio_cancel;
 	__sys_aio_cancel;
-	_aio_error;
 	__sys_aio_error;
-	_aio_fsync;
 	__sys_aio_fsync;
-	_aio_read;
 	__sys_aio_read;
-	_aio_return;
 	__sys_aio_return;
-	_aio_suspend;
 	__sys_aio_suspend;
-	_aio_waitcomplete;
 	__sys_aio_waitcomplete;
-	_aio_write;
 	__sys_aio_write;
 	_audit;
 	__sys_audit;
@@ -727,7 +719,6 @@ FBSDprivate_1.0 {
 	__sys_lgetfh;
 	_link;
 	__sys_link;
-	_lio_listio;
 	__sys_lio_listio;
 	_listen;
 	__sys_listen;

Modified: head/lib/librt/Symbol.map
==============================================================================
--- head/lib/librt/Symbol.map	Thu Jul 20 15:52:36 2017	(r321294)
+++ head/lib/librt/Symbol.map	Thu Jul 20 16:24:29 2017	(r321295)
@@ -31,16 +31,6 @@ FBSD_1.5 {
 };
 
 FBSDprivate_1.0 {
-	_aio_read;
-	_aio_write;
-	_aio_return;
-	_aio_waitcomplete;
-	_aio_fsync;
-	__aio_read;
-	__aio_write;
-	__aio_return;
-	__aio_waitcomplete;
-	__aio_fsync;
 	_mq_open;
 	_mq_close;
 	_mq_notify;

Modified: head/lib/librt/aio.c
==============================================================================
--- head/lib/librt/aio.c	Thu Jul 20 15:52:36 2017	(r321294)
+++ head/lib/librt/aio.c	Thu Jul 20 16:24:29 2017	(r321295)
@@ -39,15 +39,10 @@
 #include "sigev_thread.h"
 #include "un-namespace.h"
 
-__weak_reference(__aio_read, _aio_read);
 __weak_reference(__aio_read, aio_read);
-__weak_reference(__aio_write, _aio_write);
 __weak_reference(__aio_write, aio_write);
-__weak_reference(__aio_return, _aio_return);
 __weak_reference(__aio_return, aio_return);
-__weak_reference(__aio_waitcomplete, _aio_waitcomplete);
 __weak_reference(__aio_waitcomplete, aio_waitcomplete);
-__weak_reference(__aio_fsync, _aio_fsync);
 __weak_reference(__aio_fsync, aio_fsync);
 
 typedef void (*aio_func)(union sigval val, struct aiocb *iocb);

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201707201624.v6KGOTme014885>