Date: Mon, 25 Feb 2019 16:10:25 -0300 From: luporl <luporl@freebsd.org> To: Ian Lepore <ian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344534 - head/cddl/contrib/opensolaris/tools/ctf/cvt Message-ID: <CAC7XEcL%2BQz_mfjVRb8tKj7WjY3aK2HW4Q7MvwX5u9zXVOkO8qA@mail.gmail.com> In-Reply-To: <f1d32c1775736300c54ced74cfa4b47123b97b41.camel@freebsd.org> References: <201902251852.x1PIqlf7034853@repo.freebsd.org> <f1d32c1775736300c54ced74cfa4b47123b97b41.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry, I forgot to copy the summary from D19353. Is there a way to change it now? On Mon, Feb 25, 2019 at 3:56 PM Ian Lepore <ian@freebsd.org> wrote: > > On Mon, 2019-02-25 at 18:52 +0000, Leandro Lupori wrote: > > Author: luporl > > Date: Mon Feb 25 18:52:47 2019 > > New Revision: 344534 > > URL: https://svnweb.freebsd.org/changeset/base/344534 > > > > Log: > > Increase ctfconvert buffer size > > > > Reviewed by: markj > > Differential Revision: https://reviews.freebsd.org/D19353 > > > > This is not a very good commit message. To be good, it should say why > the size is being increased. If the commit had included the summary > text from D19353 it would have been perfect. > > -- Ian > > > Modified: > > head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > > > Modified: head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > ===================================================================== > > ========= > > --- head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon Feb > > 25 18:41:16 2019 (r344533) > > +++ head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon Feb > > 25 18:52:47 2019 (r344534) > > @@ -1268,7 +1268,7 @@ die_funcptr_create(dwarf_t *dw, Dwarf_Die die, > > Dwarf_O > > static intr_t * > > die_base_name_parse(const char *name, char **newp) > > { > > - char buf[100]; > > + char buf[256]; > > char const *base; > > char *c; > > int nlong = 0, nshort = 0, nchar = 0, nint = 0; > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAC7XEcL%2BQz_mfjVRb8tKj7WjY3aK2HW4Q7MvwX5u9zXVOkO8qA>