Date: Mon, 18 Oct 2004 10:45:11 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Ruslan Ermilov <ru@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/i386/net htonl.S ntohl.S Message-ID: <20041018174511.GA6079@dragon.nuxi.com> In-Reply-To: <20041018173516.GB89681@ip.net.ua> References: <200410181719.i9IHJa9l097436@repoman.freebsd.org> <20041018173516.GB89681@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 18, 2004 at 08:35:16PM +0300, Ruslan Ermilov wrote: > On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote: > > obrien 2004-10-18 17:19:36 UTC > > FreeBSD src repository > > Modified files: > > lib/libc/i386/net htonl.S ntohl.S > > Log: > > Sync with sys/i386/include/endian.h: use the single instruction 'bswap'. > > Revision Changes Path > > 1.10 +4 -0 src/lib/libc/i386/net/htonl.S > > 1.10 +4 -0 src/lib/libc/i386/net/ntohl.S > : ENTRY(__htonl) > : movl 4(%esp),%eax > : +#ifdef I386_CPU > : xchgb %al,%ah > : roll $16,%eax > : xchgb %al,%ah > : +#else > : + bswap %eax > : +#endif > : ret > > Ahem, but this makes this code unsuitable for i386. Yes. You missed the discussion in freebsd-current on this? For 6-CURRENT and RELENG_5 running on a real I386 is not supported. > I386_CPU > is only defined if kernel config file has "cpu I386_CPU", and > this has little relation to libc if at all. I know. Give me some other symbol then we can publish that one should add to /etc/make.conf CFLAGS to try to build a userland for an I386. "I386_CPU" looks as good a spelling as any and I didn't see any need to spell it differently than in the kernel. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041018174511.GA6079>