From owner-freebsd-hackers@FreeBSD.ORG Thu Jul 12 00:10:45 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CB6B106566C; Thu, 12 Jul 2012 00:10:45 +0000 (UTC) (envelope-from kaduk@mit.edu) Received: from dmz-mailsec-scanner-8.mit.edu (DMZ-MAILSEC-SCANNER-8.MIT.EDU [18.7.68.37]) by mx1.freebsd.org (Postfix) with ESMTP id E4DA08FC08; Thu, 12 Jul 2012 00:10:44 +0000 (UTC) X-AuditID: 12074425-b7f9b6d0000008c4-9e-4ffe1603037b Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP id 79.7D.02244.3061EFF4; Wed, 11 Jul 2012 20:10:43 -0400 (EDT) Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q6C0AgHj020760; Wed, 11 Jul 2012 20:10:42 -0400 Received: from multics.mit.edu (MULTICS.MIT.EDU [18.187.1.73]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6C0AeLM023121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 11 Jul 2012 20:10:41 -0400 (EDT) Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id q6C0Aeew019895; Wed, 11 Jul 2012 20:10:40 -0400 (EDT) Date: Wed, 11 Jul 2012 20:10:40 -0400 (EDT) From: Benjamin Kaduk To: Fabian Keil In-Reply-To: <20120711122935.1382e76d@fabiankeil.de> Message-ID: References: <1341863341.6064.11.camel@powernoodle.corp.yahoo.com> <4FFB4770.7050209@FreeBSD.org> <20120710154128.192eb8d6@fabiankeil.de> <1341939155.2573.8.camel@powernoodle.corp.yahoo.com> <20120710205702.5e57168b@fabiankeil.de> <4FFC8479.9080608@FreeBSD.org> <20120711122935.1382e76d@fabiankeil.de> User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsUixCmqrcss9s/f4PdTTovtm/8xWny6fp7J Yu7f/YwOzB5Htm5k9JjxaT5LAFMUl01Kak5mWWqRvl0CV8aV8xdYCtrFK05sncDUwPhPsIuR k0NCwESifeo1ZghbTOLCvfVsXYxcHEIC+xglWue1QTkbGCWaTixhhHAOMEkcv3idFcJpYJS4 eX8WUIaDg0VAW2LxCy6QUWwCKhIz32xkA7FFBPQkphxpBVvBLGAq8X3dZnYQW1hAR+LM1ZWs IDYn0BmdL24wg4zhFXCUWLDTCWL8OiaJmZO/MIHUiALVr94/hQXE5hUQlDg58wkLxExLiX9r f7FOYBSchSQ1C0lqASPTKkbZlNwq3dzEzJzi1GTd4uTEvLzUIl0LvdzMEr3UlNJNjKCgZXdR 3cE44ZDSIUYBDkYlHt6d6/76C7EmlhVX5h5ilORgUhLl/SHyz1+ILyk/pTIjsTgjvqg0J7X4 EKMEB7OSCO/Bl0DlvCmJlVWpRfkwKWkOFiVx3hspN/2FBNITS1KzU1MLUotgsjIcHEoSvF9A hgoWpaanVqRl5pQgpJk4OEGG8wAN3wNSw1tckJhbnJkOkT/FqMsx99KJG4xCLHn5ealS4rzK okBFAiBFGaV5cHNgyeYVozjQW8K87CBVPMBEBTfpFdASJqAlC5b+AVlSkoiQkmpgXCmxtOnF 0hthhlZzD2fsPPSnw/G8sYEf75el6UYKn3PE2eov1n3MshDYz9Q58Zs4x57LEvc+zhG+fTxb XPRkWHu+cIjbInmLJjv5OrXPf+c8Y825d3KvcIvOuROfnCdsCQ92F7TxE1zvdvZX6dP4Qzf5 fqz4v+TBA9t92akLGiye7eq72vtztRJLcUaioRZzUXEiAEPUN0kRAwAA Cc: rmacklem@freebsd.org, freebsd-hackers@freebsd.org Subject: Re: dtraceall.ko with old nfsclient X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2012 00:10:45 -0000 On Wed, 11 Jul 2012, Fabian Keil wrote: > I'm using the following modification of Sean's patch: > > diff --git a/sys/modules/dtrace/dtraceall/dtraceall.c b/sys/modules/dtrace/dtraceall/dtraceall.c > index c57f590..d50b1e5 100644 > --- a/sys/modules/dtrace/dtraceall/dtraceall.c > +++ b/sys/modules/dtrace/dtraceall/dtraceall.c > @@ -67,8 +67,11 @@ MODULE_DEPEND(dtraceall, opensolaris, 1, 1, 1); > MODULE_DEPEND(dtraceall, dtrace, 1, 1, 1); > MODULE_DEPEND(dtraceall, dtio, 1, 1, 1); > MODULE_DEPEND(dtraceall, dtmalloc, 1, 1, 1); > +#if defined (NFSCL) > MODULE_DEPEND(dtraceall, dtnfscl, 1, 1, 1); > +#elif defined (NFSCLIENT) > MODULE_DEPEND(dtraceall, dtnfsclient, 1, 1, 1); > +#endif > #if defined(__amd64__) || defined(__i386__) > MODULE_DEPEND(dtraceall, fbt, 1, 1, 1); > MODULE_DEPEND(dtraceall, fasttrap, 1, 1, 1); > > The perceived problem is that after compiling dtraceall with > "make buildkernel", installing it with "make installkernel" > and rebooting, loading it results in: > > fk@r500 ~ $kldstat > Id Refs Address Size Name > 1 73 0xffffffff80200000 e492c0 kernel > 2 1 0xffffffff8104a000 226928 zfs.ko > 3 14 0xffffffff81271000 82b8 opensolaris.ko > 4 1 0xffffffff8127a000 23a48 geom_eli.ko > 5 2 0xffffffff8129e000 34380 crypto.ko > 7 1 0xffffffff812fe000 8640 acpi_video.ko > 8 1 0xffffffff81307000 7d00 acpi_ibm.ko > 9 4 0xffffffff81412000 29e31 usb.ko > 10 1 0xffffffff8143c000 32ec usb_quirk.ko > 11 1 0xffffffff81440000 bded ehci.ko > 12 1 0xffffffff8144c000 8d02 umass.ko > 13 1 0xffffffff81455000 5c2a nullfs.ko > 14 1 0xffffffff8145b000 51ac fdescfs.ko > 15 1 0xffffffff81461000 beb4 i915.ko > 16 1 0xffffffff8146d000 173cc drm.ko > 17 1 0xffffffff81485000 b25 dtraceall.ko > 18 1 0xffffffff81486000 4e00 profile.ko > 19 3 0xffffffff8148b000 4073 cyclic.ko > 20 10 0xffffffff81490000 23b931 dtrace.ko > 21 1 0xffffffff816cc000 125da systrace_freebsd32.ko > 22 1 0xffffffff816df000 13797 systrace.ko > 23 1 0xffffffff816f3000 44be sdt.ko > 24 1 0xffffffff816f8000 484d lockstat.ko > 25 1 0xffffffff816fd000 bce5 fasttrap.ko > 26 1 0xffffffff81709000 6553 fbt.ko > 27 1 0xffffffff81710000 448b dtmalloc.ko > 28 1 0xffffffff81715000 43d9 dtio.ko > > Note that dtnfscl.ko is not loaded even though loading > it manually works and I have NFSCL in the kernel. This is because dtraceall.c only #includes opt_compat.h, and the kernel build system only passes -include opt_global.h, so the dtraceall module build has no way of knowing about the NFSCL{IENT,} options defined in opt_nfs.h. (As you noted earlier in the thread?) You would still need to address Andriy's comments in order to ensure that the configuration seen by the module matches the kernel. -Ben Kaduk