Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Aug 1999 20:42:16 +0400
From:      Dmitrij Tejblum <tejblum@arc.hq.cti.ru>
To:        Alfred Perlstein <bright@wintelcom.net>
Cc:        hackers@FreeBSD.ORG, fs@FreeBSD.ORG
Subject:   Re: HEADS UP Reviewers. VFS changes to be committed. 
Message-ID:  <199908261642.UAA07357@arc.hq.cti.ru>
In-Reply-To: Your message of "Thu, 26 Aug 1999 08:28:29 -0000." <Pine.BSF.4.05.9908260220590.6392-100000@fw.wintelcom.net> 

next in thread | previous in thread | raw e-mail | index | archive | help
Just a few comments...

> 2) The casting of VFS ops to eopnotsupp() has been removed and
>      vfs_nop*() functions have been put into kern/vfs_default.c
> 
>    This makes it more clear that certain VFS-ops are giving default
>    behavior, either returning automatic success or returning EOPNOTSUPP.

I like the idea. (However, I think that the functions returning failure 
should not be called NOPs.)

> Why does VFS_CHECKEXP take a vnode and not a mount point? 
> Hopefully in the future a filesystem will be able to more 
> restrictively export its files, this will help facilitate that.

IMO, if it take a vnode, it should be VOP_CHECKEXP, not VFS_CHECKEXP.

Dima




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-fs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199908261642.UAA07357>