Date: Wed, 17 Nov 1999 02:20:02 -0800 (PST) From: Maxim Sobolev <sobomax@altavista.net> To: freebsd-ports@FreeBSD.org Subject: Re: ports/14889: [PATCH] dynamic loading for WINE port Message-ID: <199911171020.CAA95318@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/14889; it has been noted by GNATS.
From: Maxim Sobolev <sobomax@altavista.net>
To: Juergen Lock <nox@jelal.kn-bremen.de>
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: ports/14889: [PATCH] dynamic loading for WINE port
Date: Wed, 17 Nov 1999 12:15:59 +0200
This is a multi-part message in MIME format.
--------------0423EB76B501FA9E2D886303
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 7bit
Juergen Lock wrote:
> On Tue, Nov 16, 1999 at 10:55:40AM +0200, Maxim Sobolev wrote:
> > Juergen Lock wrote:
> >
> > > In article <19991115024901.CEEF314C1C@hub.freebsd.org> you write:
>
> this should correctly list the symbols and line numbers, at least
> for those stack frames that point into wine code... (If your not
> sure you can mail me the backtrace of course.)
Thanks for detailed explanation. It seems not wery complicated and I'll try to follow
it and let you know about results. Have I understand correctly that for debugger to
work WINE should be compiled with -g and installed unstripped?
> > Please be my guest
> > (if you can of course) to test it.
> >
> Well my first priority on the port is the upgrade to 991114 and to
> adjust for the sigcontext change that was just MFC'd... (which should
> enable signal handling of a wine thats built on -stable to run
> correctly on -current as well.)
In the wine-devel list I found small patch for recently added ptrace.c and attaching
it with this message because it would be useful for your work on porting 991114.
> > space constrains want it to be. Thus we will give user a choice which IMHO is
> > always better than no-choice case.
> >
> make NO_DEBUG=yes?
>
> could probably be added for that, with an appropriate warning...
It is exactly what I want it to be.
Sincerely,
Maxim
--------------0423EB76B501FA9E2D886303
Content-Type: text/plain; charset=koi8-r;
name="patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="patch"
*** ptrace.c Mon Nov 15 16:18:16 1999
--- ptrace..c~ Mon Nov 15 14:45:43 1999
***************
*** 10,20 ****
#include <errno.h>
#include <stdio.h>
#include <signal.h>
- #include <sys/ptrace.h>
#ifdef HAVE_SYS_WAIT_H
#include <sys/wait.h>
#endif
#include <unistd.h>
#include "process.h"
#include "thread.h"
--- 10,20 ----
#include <errno.h>
#include <stdio.h>
#include <signal.h>
#ifdef HAVE_SYS_WAIT_H
#include <sys/wait.h>
#endif
#include <unistd.h>
+ #include <sys/ptrace.h>
#include "process.h"
#include "thread.h"
***************
*** 142,148 ****
/* read an int from a thread address space */
int read_thread_int( struct thread *thread, const int *addr, int *data )
{
! if (((*data = ptrace( PTRACE_PEEKDATA, thread->unix_pid, addr )) == -1) && errno)
{
file_set_error();
return -1;
--- 142,148 ----
/* read an int from a thread address space */
int read_thread_int( struct thread *thread, const int *addr, int *data )
{
! if (((*data = ptrace( PTRACE_PEEKDATA, thread->unix_pid, (caddr_t)addr, NULL )) == -1) && errno)
{
file_set_error();
return -1;
***************
*** 159,164 ****
if (read_thread_int( thread, addr, &res ) == -1) return -1;
data = (data & mask) | (res & ~mask);
}
! if ((res = ptrace( PTRACE_POKEDATA, thread->unix_pid, addr, data )) == -1) file_set_error();
return res;
}
--- 159,164 ----
if (read_thread_int( thread, addr, &res ) == -1) return -1;
data = (data & mask) | (res & ~mask);
}
! if ((res = ptrace( PTRACE_POKEDATA, thread->unix_pid, (caddr_t)addr, data )) == -1) file_set_error();
return res;
}
--------------0423EB76B501FA9E2D886303--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199911171020.CAA95318>