Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 6 Mar 2021 16:43:05 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Rainer Hurling <rhurlin@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r561652 - in head/databases: libgda5-mdb mdbtools mdbtools/files recutils
Message-ID:  <20210306164305.GA32516@FreeBSD.org>
In-Reply-To: <202101151716.10FHGPeF016819@repo.freebsd.org>
References:  <202101151716.10FHGPeF016819@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 15, 2021 at 05:16:25PM +0000, Rainer Hurling wrote:
> New Revision: 561652
> URL: https://svnweb.freebsd.org/changeset/ports/561652
> 
> Log:
>   databases/mdbtools: Update to 0.9.1
>   
>   - Switch to a new fork on Github
>   - Split NLS (gettext) as an option
>   - Remove gmdb2 GUI (will come back as own port)
>   
> Differential Revision:	https://reviews.freebsd.org/D28118

DR subject says "update to 0.9.2", but the port was updated to 0.9.1,
are there some problems with 0.9.2?

> ...
> Modified: head/databases/mdbtools/Makefile
> ==============================================================================
> --- head/databases/mdbtools/Makefile	Fri Jan 15 15:57:58 2021	(r561651)
> +++ head/databases/mdbtools/Makefile	Fri Jan 15 17:16:25 2021	(r561652)
> @@ -1,8 +1,8 @@
> -# Created by: Anders Nordby <anders@fix.no>

We typically keep these lines out of respect to the original port author
and appreciation of their efforts.  While they are optional for new ports,
one should not remove them unless under explicit concent of that person.
Did you obtain that from Anders?

> +USE_GITHUB=	yes
> +GH_ACCOUNT=	mdbtools

This is the default valute for GH_ACCOUNT so no need to set it.

> Modified: head/databases/recutils/Makefile
> ==============================================================================
> --- head/databases/recutils/Makefile	Fri Jan 15 15:57:58 2021	(r561651)
> +++ head/databases/recutils/Makefile	Fri Jan 15 17:16:25 2021	(r561652)
> @@ -3,6 +3,7 @@
>  
>  PORTNAME=	recutils
>  PORTVERSION=	1.8
> +PORTREVISION=	1

You should've checked all consumer ports that they actually can build
against updated port, no just merely bump port revision, even if this
dependency is optional and disabled by default.  There had been some
changes in public API so `databases/recutils' failed to build with MDB
option enabled.  I've fixed the port in r567461 and enabled MDB by
default so this breakage could be caught earlier next time.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210306164305.GA32516>