Skip site navigation (1)Skip section navigation (2)
Date:      28 Sep 2000 22:15:56 +0200
From:      Dag-Erling Smorgrav <des@ofug.org>
To:        cvs-committers@FreeBSD.org
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/savecore savecore.c
Message-ID:  <xzp3dike0hv.fsf@flood.ping.uio.no>
In-Reply-To: Dag-Erling Smorgrav's message of "Thu, 28 Sep 2000 13:09:37 -0700 (PDT)"
References:  <200009282009.NAA38027@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Dag-Erling Smorgrav <des@FreeBSD.org> writes:
>   Remove superfluous code:
>   [...]

(this is almost, but not quite, the patch I posted to -developers)

Two things of interest regarding devname():

  1) the current implementation of devname() never returns NULL, so
     find_dev() in savecore.c is overly defensive.

  2) the devname(3) man page is out of sync with the code, since
     devname() now never returns NULL, and the fallback is not "??"
     but "#X:maj:min" where X is either "C" or "B" depending on the
     device type.

DES
-- 
Dag-Erling Smorgrav - des@ofug.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp3dike0hv.fsf>