Date: Wed, 22 Apr 2009 07:48:39 +1000 From: Peter Jeremy <peterjeremy@optushome.com.au> To: FreeBSD-gnats-submit@FreeBSD.org Cc: peterjeremy@optushome.com.au, phil.kim@alcatel-lucent.com.au Subject: ports/133899: korean/ami doesn't work on amd64 Message-ID: <20090421214839.GA24950@server.vk2pj.dyndns.org> Resent-Message-ID: <200904212150.n3LLo2pr097632@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133899
>Category: ports
>Synopsis: korean/ami doesn't work on amd64
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 21 21:50:00 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Peter Jeremy
>Release: FreeBSD 7.0-STABLE amd64
>Organization:
n/a
>Environment:
System: FreeBSD pjdesk.au.alcatel-lucent.com 7.0-STABLE FreeBSD 7.0-STABLE #7: Thu Apr 10 10:50:36 EST 2008 root@pjdesk.alcatel.com.au:/var/obj/usr/src/sys/pjdesk amd64
>Description:
When attempting to input Hangul via ami on an amd64 system,
garbage CJK characters were displayed.
>How-To-Repeat:
On an amd64 system, enable "2 BUL" mode and attempt to enter
Hangul characters in an XIM-enabled text box.
>Fix:
Examination of compiler warnings shows several cases where (int*)
is passed to a function expecting (size_t *). The following
patches appear to fix the problem and make ami work correctly.
--- src/hanja.c~ 2003-02-06 09:52:42.000000000 +1100
+++ src/hanja.c 2009-04-21 13:43:59.000000000 +1000
@@ -345,7 +345,7 @@
if ( ami_codeset==AMI_UTF8) {
/* U+AC00 -> EAB080, U+D7A3 -> ED9EA3 */
- int ilen,olen;
+ size_t ilen,olen;
char *iptr=word;
char *optr;
@@ -399,8 +399,8 @@
if ( ami_codeset==AMI_EUC)
match=g_strdup(s);
else {
- int ilen=strlen(s)+1;
- int olen=ilen*2;
+ size_t ilen=strlen(s)+1;
+ size_t olen=ilen*2;
char *iptr=s;
char *optr;
match=g_new(gchar,olen);
--- src/johabcode2.c~ 2003-01-27 10:26:03.000000000 +1100
+++ src/johabcode2.c 2009-04-21 13:39:56.000000000 +1000
@@ -40,7 +40,7 @@
int
johab_to_wansung(char *s, int johab)
{
- int in_len, out_len;
+ size_t in_len, out_len;
char in[2];
char *in_p, *out_p;
if (johab < 128) {
@@ -68,8 +68,8 @@
{
char *out_p = s;
char *in_p = johab;
- int in_len = len;
- int out_len = len;
+ size_t in_len = len;
+ size_t out_len = len;
if (johab_to_wan_cd == (iconv_t) -1) {
johab_to_wan_cd = iconv_open(CD_EUC_KR, CD_JOHAB);
if (johab_to_wan_cd == (iconv_t) -1) {
@@ -84,7 +84,7 @@
int
johab_from_wansung(char *s, int wansung)
{
- int in_len, out_len;
+ size_t in_len, out_len;
char in[2];
char *in_p, *out_p;
if (wansung < 128) {
@@ -112,8 +112,8 @@
{
char *out_p = s;
char *in_p = wansung;
- int in_len = len;
- int out_len = len;
+ size_t in_len = len;
+ size_t out_len = len;
if (wan_to_johab_cd == (iconv_t) -1) {
wan_to_johab_cd = iconv_open(CD_JOHAB, CD_EUC_KR);
if (wan_to_johab_cd == (iconv_t) -1) {
@@ -155,7 +155,7 @@
int
johab_to_utf8(char *s, int johab)
{
- int in_len, out_len;
+ size_t in_len, out_len;
char in[2];
char *in_p, *out_p;
if (johab < 128) {
--- src/si.c~ 2003-01-27 10:26:03.000000000 +1100
+++ src/si.c 2009-04-21 13:39:54.000000000 +1000
@@ -174,7 +174,7 @@
else {
char tbuf[3];
char *iptr,*optr;
- int ilen,olen;
+ size_t ilen,olen;
for (i = 0; i < row*col; i++) {
tbuf[0] = first;
tbuf[1] = k++;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090421214839.GA24950>