Date: Mon, 21 Nov 2011 22:53:43 +0000 From: Alexander Best <arundel@freebsd.org> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-wireless@freebsd.org Subject: Re: issues with the recent ath commits (r227740, r227651, ...) Message-ID: <20111121225343.GA19155@freebsd.org> In-Reply-To: <20111121221224.GA11508@freebsd.org> References: <20111121131730.GA3599@freebsd.org> <alpine.BSF.2.00.1111210719430.30516@wonkity.com> <20111121152054.GA22220@freebsd.org> <CAJ-VmomzY6Arh_=nPihdH=RhNyQXV7jgdvV7oyGKfqzb1BQ6sw@mail.gmail.com> <alpine.BSF.2.00.1111211433100.33629@wonkity.com> <CAJ-VmomO-7-TsT1b_=2FBu5rnYf7Z5UhQyuRF95iupiL2xGTnA@mail.gmail.com> <20111121221224.GA11508@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon Nov 21 11, Alexander Best wrote:
> On Tue Nov 22 11, Adrian Chadd wrote:
> > Hi,
> >
> > Please try this patch:
>
> looking very promising so far. haven't got the boot-up-panic. i'll let my
> system run for a few hours, to see, if the lock up has also been resolved.
ok. after > 45 minutes uptime i can confirm that the patch fixes the issues i
experienced beforehand. unless i didn't get a boot-up-panic, my system locked
up after < 5 minutes.
however using your patch i noticed the following console output:
ath0: ath_start: sc_inreset_cnt > 0; bailing
... only once, however. i don't believe i've seen this one ever beforehand.
cheers.
alex
>
> cheers.
> alex
>
> >
> >
> > commit 3993972ed7407867dce188903f68a0751c487fbb
> > Author: Adrian Chadd <adrian@freebsd.org>
> > Date: Tue Nov 22 05:28:16 2011 +0800
> >
> > Sleep on the correct lock.
> >
> > diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c
> > index 83c5ede..84cb91b 100644
> > --- a/sys/dev/ath/if_ath.c
> > +++ b/sys/dev/ath/if_ath.c
> > @@ -1878,9 +1878,9 @@ ath_txrx_stop(struct ath_softc *sc)
> > */
> > while (sc->sc_rxproc_cnt || sc->sc_txproc_cnt ||
> > sc->sc_txstart_cnt || sc->sc_intr_cnt) {
> > - if (i <= 0)
> > + if (i <= 0)
> > break;
> > - msleep(sc, &sc->sc_mtx, 0, "ath_txrx_stop", 1);
> > + msleep(sc, &sc->sc_pcu_mtx, 0, "ath_txrx_stop", 1);
> > i--;
> > }
> > ATH_PCU_UNLOCK(sc);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111121225343.GA19155>