From owner-svn-src-all@FreeBSD.ORG Tue Jul 27 14:49:44 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 978BF1065676; Tue, 27 Jul 2010 14:49:44 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245]) by mx1.freebsd.org (Postfix) with ESMTP id 298A98FC19; Tue, 27 Jul 2010 14:49:43 +0000 (UTC) Received: from mail-gw6.york.ac.uk (mail-gw6.york.ac.uk [144.32.129.26]) by mail-gw0.york.ac.uk (8.13.6/8.13.6) with ESMTP id o6REnf3Y011589; Tue, 27 Jul 2010 15:49:41 +0100 (BST) Received: from buffy-128.york.ac.uk ([144.32.128.160] helo=buffy.york.ac.uk) by mail-gw6.york.ac.uk with esmtps (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1OdlTR-0007UW-8z; Tue, 27 Jul 2010 15:49:41 +0100 Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.14.4/8.14.4) with ESMTP id o6REnfPF080508; Tue, 27 Jul 2010 15:49:41 +0100 (BST) (envelope-from gavin@FreeBSD.org) Received: (from ga9@localhost) by buffy.york.ac.uk (8.14.4/8.14.4/Submit) id o6REneR2080507; Tue, 27 Jul 2010 15:49:40 +0100 (BST) (envelope-from gavin@FreeBSD.org) X-Authentication-Warning: buffy.york.ac.uk: ga9 set sender to gavin@FreeBSD.org using -f From: Gavin Atkinson To: Jung-uk Kim In-Reply-To: <201007261953.o6QJrAFd069188@svn.freebsd.org> References: <201007261953.o6QJrAFd069188@svn.freebsd.org> Content-Type: text/plain; charset="ASCII" Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Jul 2010 15:49:40 +0100 Message-ID: <1280242180.78791.33.camel@buffy.york.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 FreeBSD GNOME Team Port X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin@freebsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r210514 - in head/sys/amd64: acpica amd64 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jul 2010 14:49:44 -0000 On Mon, 2010-07-26 at 19:53 +0000, Jung-uk Kim wrote: > Author: jkim > Date: Mon Jul 26 19:53:09 2010 > New Revision: 210514 > URL: http://svn.freebsd.org/changeset/base/210514 >=20 > Log: > Re-implement FPU suspend/resume for amd64. This removes superfluous us= es > of critical_enter(9) and critical_exit(9) by fpugetregs() and fpusetreg= s(). > Also, we do not touch PCB flags any more. Hi, Is this likely to make suspend.resume more reliable? Or is it basically more of a tidy up of the existing code? My laptop hangs on resume maybe 1 in 5 times, but will also hang 100% of the time if I've been running virtualbox - and as a result I'm assuming it's somethign to do with some register saving/restoring that needs to happen but isn't at the moment. I have no idea how to debug the problem further though. Thanks, Gavin --=20 Gavin Atkinson FreeBSD committer and bugmeister