From owner-dev-commits-ports-all@freebsd.org Tue Jun 8 02:00:58 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2C22A6576A6; Tue, 8 Jun 2021 02:00:58 +0000 (UTC) (envelope-from meta@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FzYP60d63z4v87; Tue, 8 Jun 2021 02:00:58 +0000 (UTC) (envelope-from meta@freebsd.org) Received: from ssl.vmeta.jp (unknown [IPv6:2405:6586:2280:1200:11af:7103:75da:552d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7691C2DEC; Tue, 8 Jun 2021 02:00:56 +0000 (UTC) (envelope-from meta@freebsd.org) MIME-Version: 1.0 Date: Tue, 08 Jun 2021 11:00:52 +0900 From: Koichiro Iwao To: Mathieu Arnold Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: beff5e37902f - main - sysutils/mackerel-agent: Update to 0.71.2 In-Reply-To: <20210530071948.jzjlbgepvhexf35l@aching.in.mat.cc> References: <202105291644.14TGiYHK003156@gitrepo.freebsd.org> <20210530071948.jzjlbgepvhexf35l@aching.in.mat.cc> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <5461673c056632e25c4f64c99e597983@freebsd.org> X-Sender: meta@freebsd.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 02:00:58 -0000 Matt wrote: > DIST_SUBDIR should only be used when the distribution files are not > versionned or conflict with others, in this case, I don't see any > reason > to use it. > > Moreover, with all those distribution files, there is a good chance > that > some other port needs the same file, using DIST_SUBDIR makes it > impossible to share those files, and forces users to fetch the same > things multiple times, somewhat defeating the reason of the distfiles > directory. Understood. Thanks for the advice. That is reasonable not to use DIST_SUBDIR. I felt a single port putting many files directly under distfiles directory looks clutter but your point is quite correct. -- meta