From owner-svn-src-all@FreeBSD.ORG Thu Jul 10 16:46:47 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4C3E5B50; Thu, 10 Jul 2014 16:46:47 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 397812D58; Thu, 10 Jul 2014 16:46:47 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.8/8.14.8) with ESMTP id s6AGklMl090325; Thu, 10 Jul 2014 16:46:47 GMT (envelope-from markj@svn.freebsd.org) Received: (from markj@localhost) by svn.freebsd.org (8.14.8/8.14.8/Submit) id s6AGklRR090324; Thu, 10 Jul 2014 16:46:47 GMT (envelope-from markj@svn.freebsd.org) Message-Id: <201407101646.s6AGklRR090324@svn.freebsd.org> From: Mark Johnston Date: Thu, 10 Jul 2014 16:46:47 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r268501 - head/sys/dev/e1000 X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jul 2014 16:46:47 -0000 Author: markj Date: Thu Jul 10 16:46:46 2014 New Revision: 268501 URL: http://svnweb.freebsd.org/changeset/base/268501 Log: Correct the setting of the VID in transmit descriptors when hardware VLAN tagging is enabled. This was broken in r266978. Reported by: gjb Tested by: gjb Modified: head/sys/dev/e1000/if_em.c Modified: head/sys/dev/e1000/if_em.c ============================================================================== --- head/sys/dev/e1000/if_em.c Thu Jul 10 16:10:39 2014 (r268500) +++ head/sys/dev/e1000/if_em.c Thu Jul 10 16:46:46 2014 (r268501) @@ -2012,7 +2012,7 @@ retry: if (m_head->m_flags & M_VLANTAG) { /* Set the vlan id. */ - txd_upper |= htole16((if_getvtag(m_head)) << 16); + txd_upper |= htole16(if_getvtag(m_head)) << 16; /* Tell hardware to add tag */ txd_lower |= htole32(E1000_TXD_CMD_VLE); }