Date: Sun, 11 Dec 2011 16:26:54 GMT From: Barbara <barbara.xxx1975@libero.it> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/163182: net-p2p/amule: fix libpng check in configure Message-ID: <201112111626.pBBGQsCB022350@red.freebsd.org> Resent-Message-ID: <201112111630.pBBGU1ZZ063991@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 163182
>Category: ports
>Synopsis: net-p2p/amule: fix libpng check in configure
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 11 16:30:01 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Barbara
>Release: RELENG_8
>Organization:
>Environment:
FreeBSD satanasso.local.net 8.2-STABLE FreeBSD 8.2-STABLE #0: Sun Nov 13 20:08:29 CET 2011 root@satanasso.local.net:/usr/obj/usr/src/sys/SATANASSO i386
>Description:
In my previous submission (pr=162603) which has been committed, I added -lpng in LDFLAGS to force the use of libpng, as the test in configure was failing.
It turned out, thanks to a friend of mine, that there is a problem with bashism in configure (actually in m4/libpng.m4).
So I added a patch for configure in files/, and restored LDFLAGS.
The fix has been pushed upstream and committed in SVN revision 10694.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
--- Makefile.orig 2011-11-30 22:20:54.000000000 +0100
+++ Makefile 2011-12-11 17:14:25.000000000 +0100
@@ -7,6 +7,7 @@
PORTNAME= amule
PORTVERSION= 2.3.1
+PORTREVISION= 1
CATEGORIES= net-p2p
MASTER_SITES= SF/${PORTNAME}/aMule/${PORTVERSION}
DISTNAME= aMule-${PORTVERSION}
@@ -37,7 +38,7 @@
CPPFLAGS+= -I${LOCALBASE}/include
CFLAGS+= ${PTHREAD_CFLAGS}
-LDFLAGS+= ${PTHREAD_LIBS} -L${LOCALBASE}/lib -lpng
+LDFLAGS+= ${PTHREAD_LIBS} -L${LOCALBASE}/lib
OPTIONS= ALC "Compile aMule Link Creator for GUI" on \
ALCC "Compile aMule Link Creator for console" on \
--- files/patch-configure.orig 1970-01-01 01:00:00.000000000 +0100
+++ files/patch-configure 2011-12-11 17:11:34.000000000 +0100
@@ -0,0 +1,15 @@
+--- configure.orig 2011-11-11 21:59:26.000000000 +0100
++++ configure 2011-12-11 17:11:22.000000000 +0100
+@@ -7360,9 +7360,9 @@
+ SAVED_LDFLAGS=$LDFLAGS
+ SAVED_LIBS=$LIBS
+
+- CFLAGS+=" $LIBPNG_CFLAGS"
+- LDFLAGS+=" $LIBPNG_LDFLAGS"
+- LIBS+=" $LIBPNG_LIBS"
++ CFLAGS="$CFLAGS $LIBPNG_CFLAGS"
++ LDFLAGS="$LDFLAGS $LIBPNG_LDFLAGS"
++ LIBS="$LIBS $LIBPNG_LIBS"
+
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+ /* end confdefs.h. */
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112111626.pBBGQsCB022350>