From owner-freebsd-arm@FreeBSD.ORG Mon Nov 19 23:08:47 2012 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B4AE6F79 for ; Mon, 19 Nov 2012 23:08:47 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-qa0-f54.google.com (mail-qa0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id 608488FC0C for ; Mon, 19 Nov 2012 23:08:47 +0000 (UTC) Received: by mail-qa0-f54.google.com with SMTP id g24so467118qab.13 for ; Mon, 19 Nov 2012 15:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LD3XMV7oX//XuTXt9RTF3TiiuHVUNOTiaK6Mr1PQeIY=; b=EZvIorFRcsymJRbGm3bPC1oubkGWh0SG88ft1iqHbzPte/z+UU8jK23TQzOHavc/Nu 7IoOdDY+6kt4gwI0a/i89Yo1us61C11Zbw9pmFr0yyGVP5+AeLvKcqDuxmEFuncQUARq FxuLz9h2fbvUUR33DOrAMBtaXCWbOswRdVQ+jmEG2PMh7hg1UCo43i7P30YpI0YpDFit fFe3Uwq06ZtR5lDziSc39NcbzYZ4n+JaX9JtA78avCPSC307iikkki4eO/A6K5/Hc0Av jjNzchXvVNGrYHVYShigyatH0x4veb9vpKHiUkRMzU5cFfWpCjwE/Uije8xQRFaYXxcs Xhuw== MIME-Version: 1.0 Received: by 10.49.97.3 with SMTP id dw3mr15051447qeb.35.1353366521299; Mon, 19 Nov 2012 15:08:41 -0800 (PST) Sender: giovanni.trematerra@gmail.com Received: by 10.229.117.1 with HTTP; Mon, 19 Nov 2012 15:08:41 -0800 (PST) In-Reply-To: <50AA4E87.3000505@semihalf.com> References: <50AA4E87.3000505@semihalf.com> Date: Tue, 20 Nov 2012 00:08:41 +0100 X-Google-Sender-Auth: a0nWk7xQf_fjLskjRfUgZOrampI Message-ID: Subject: Re: ARM/SMP, Some patches for review. From: Giovanni Trematerra To: =?UTF-8?B?xYF1a2FzeiBQxYJhY2hubw==?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-arm@freebsd.org X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2012 23:08:47 -0000 On Mon, Nov 19, 2012 at 4:21 PM, =C5=81ukasz P=C5=82achno wrote: > Hi, > > I would like to propose few changes for ARM specific code. > Three attached patches for freebsd-current allows building SMP-safe world > for ARM targets and turns on TEX remap for ARMv6 and ARMv7 targets. > > More details inside patch files. > > Change introduced by "commit-2" removes armv7 targets (armv7 and pj4b) fr= om > kernel.tramp. > AFAIK this feature is not working properly for armv7 targets and is causi= ng > problem during compilation: > - LOCORE is defined during kernel compilation but not defined during > kernel.tramp compilation, so #include pmap.h causes build errors. > > I do not think adding hack like this: > #ifndef LOCORE > #define LOCORE > #endif > > to allow building something that is already broken is a good idea, so I > removed cpufunc_asm_pj4b.S and cpufunc_asm_armv7.S from Makefile.arm In commit-2.txt you should include style changes in sys/arm/arm/cpufunc_asm_armv7.S into a different patch. @@ -63,7 +64,6 @@ FILES_CPU_FUNC =3D $S/$M/$M/cpufunc_asm_arm7tdmi.S \ $S/$M/$M/cpufunc_asm_xscale.S $S/$M/$M/cpufunc_asm.S \ $S/$M/$M/cpufunc_asm_xscale_c3.S $S/$M/$M/cpufunc_asm_armv5_ec.S \ $S/$M/$M/cpufunc_asm_fa526.S $S/$M/$M/cpufunc_asm_sheeva.S \ - $S/$M/$M/cpufunc_asm_pj4b.S $S/$M/$M/cpufunc_asm_armv7.S You left a trailing back slash but beside that you should clean up sys/arm/arm/elf_trampoline.c and not make kernel.tramp to build at all for armv7 cpus or you'll end up with a linker error during generation of the kernel.tramp. -- Gianni