Date: Tue, 29 May 2012 22:19:29 +0100 From: Chris Rees <crees@FreeBSD.org> To: Jason Helfman <jgh@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org> Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.options.desc.mk Message-ID: <CADLo83-AGnTXe-MboVLx4Oe0W09-JxG-5QcSqevTb-c_BoLa7A@mail.gmail.com> In-Reply-To: <20120529205342.GG31475@dormouse.experts-exchange.com> References: <201205292019.q4TKJR9V040505@repoman.freebsd.org> <20120529205342.GG31475@dormouse.experts-exchange.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29 May 2012 21:53, Jason Helfman <jgh@freebsd.org> wrote: > On Tue, May 29, 2012 at 08:19:27PM +0000, Chris Rees thus spake: > >> crees =A0 =A0 =A0 2012-05-29 20:19:27 UTC >> >> =A0FreeBSD ports repository >> >> =A0Modified files: >> =A0 Mk =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 bsd.options.desc.mk >> =A0Log: >> =A0Apparently parentheses are not allowed >> >> =A0Revision =A0Changes =A0 =A0Path >> =A01.19 =A0 =A0 =A0+3 -3 =A0 =A0 =A0ports/Mk/bsd.options.desc.mk >> >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/Mk/bsd.options.desc.mk.diff?= &r1=3D1.18&r2=3D1.19&f=3Dh >> > > Perhaps informational text at the top of the mk should list what isn't > allowed, such as parentheticals. Bapt, opinions? Log: Add comment advising not to use parentheses and quotes While here, make a few minor corrections. RCS file: /home/pcvs/ports/Mk/bsd.options.desc.mk,v retrieving revision 1.19 diff -u -r1.19 bsd.options.desc.mk --- bsd.options.desc.mk 29 May 2012 20:19:27 -0000 1.19 +++ bsd.options.desc.mk 29 May 2012 21:17:09 -0000 @@ -2,6 +2,8 @@ # # Please keep descriptions sorted alphabetically by variable name. # +# Note: use of (parentheses) and "quotes" can cause problems, so it is +# advisable to leave these out. Options_Desc_MAINTAINER=3D ports@FreeBSD.org @@ -9,7 +11,7 @@ AO_DESC?=3D Support libao audio library ARCHIVE_DESC?=3D Support bzip2/zip/iso9660 archive AVAHI_DESC?=3D Support Zeroconf through Avahi -CDDA2WAV_DESC?=3D Enable cdda2was CD ripper +CDDA2WAV_DESC?=3D Enable cdda2wav CD ripper CUE_DESC?=3D Support embedded cue sheets CURL_DESC?=3D Enable CURL support DAGRAB_DESC?=3D Enable dagrab CD ripper @@ -31,7 +33,7 @@ IPV6_DESC?=3D Enable IPv6 support JACK_DESC?=3D Support JACK audio server JPEG_DESC?=3D Enable JPEG support -LAME_DESC?=3D Support for MP3 Icecast Streams +LAME_DESC?=3D Support for LAME MP3 LASTFM_DESC?=3D Support Last.FM stream input LDAP_DESC?=3D Enable LDAP support MAGICK_DESC?=3D Enable ImageMagick Library http://www.bayofrum.net/~crees/patches/bsd.options.desc.mk-comment-special-= chars.diff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-AGnTXe-MboVLx4Oe0W09-JxG-5QcSqevTb-c_BoLa7A>