From owner-cvs-ports@FreeBSD.ORG Tue May 29 21:20:02 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 99DCC106566B; Tue, 29 May 2012 21:20:02 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6A6488FC15; Tue, 29 May 2012 21:20:01 +0000 (UTC) Received: by bkvi18 with SMTP id i18so4634124bkv.13 for ; Tue, 29 May 2012 14:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=X8f1hWAniGYkSh5B7ZXMYb1L12XdT8Nj4ktcXNjHnsw=; b=h4kCDLxHUvp7pz59PaLEb/awPpCHBCMRal1KXTKGEcIFBXDAQR6zZRuDL2hSJYXSig iSiYV+FM9uHLooLMYj7JBSpJSb15/qsXdSni1/tCaBpjJNgdQqTCYReovA25/5xzFQ/u ZXaRvwX3BkpsMZIpbKh46kPMa2nX38v3InR5j+woHu5lXGOJb8EqI7PDmBo2Idf+HntO E+g2cPy+gIeNWp5Udpo+2ltd5xZAKq1+sXsUQuiTBXCGYJBPod5aijMuLBptnYOCOgnX Nb4vzrEtwata2XAt6WfbJkm/Bxe73ukVcf+/+heofMuiYl5RXa46htGcL6mhm+qaJWFF u4gQ== Received: by 10.205.33.136 with SMTP id so8mr7072224bkb.1.1338326400219; Tue, 29 May 2012 14:20:00 -0700 (PDT) MIME-Version: 1.0 Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Tue, 29 May 2012 14:19:29 -0700 (PDT) In-Reply-To: <20120529205342.GG31475@dormouse.experts-exchange.com> References: <201205292019.q4TKJR9V040505@repoman.freebsd.org> <20120529205342.GG31475@dormouse.experts-exchange.com> From: Chris Rees Date: Tue, 29 May 2012 22:19:29 +0100 X-Google-Sender-Auth: Lk7XPlViv_Vb3xtemaqFtciuxHQ Message-ID: To: Jason Helfman , Baptiste Daroussin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/Mk bsd.options.desc.mk X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2012 21:20:02 -0000 On 29 May 2012 21:53, Jason Helfman wrote: > On Tue, May 29, 2012 at 08:19:27PM +0000, Chris Rees thus spake: > >> crees =A0 =A0 =A0 2012-05-29 20:19:27 UTC >> >> =A0FreeBSD ports repository >> >> =A0Modified files: >> =A0 Mk =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 bsd.options.desc.mk >> =A0Log: >> =A0Apparently parentheses are not allowed >> >> =A0Revision =A0Changes =A0 =A0Path >> =A01.19 =A0 =A0 =A0+3 -3 =A0 =A0 =A0ports/Mk/bsd.options.desc.mk >> >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/Mk/bsd.options.desc.mk.diff?= &r1=3D1.18&r2=3D1.19&f=3Dh >> > > Perhaps informational text at the top of the mk should list what isn't > allowed, such as parentheticals. Bapt, opinions? Log: Add comment advising not to use parentheses and quotes While here, make a few minor corrections. RCS file: /home/pcvs/ports/Mk/bsd.options.desc.mk,v retrieving revision 1.19 diff -u -r1.19 bsd.options.desc.mk --- bsd.options.desc.mk 29 May 2012 20:19:27 -0000 1.19 +++ bsd.options.desc.mk 29 May 2012 21:17:09 -0000 @@ -2,6 +2,8 @@ # # Please keep descriptions sorted alphabetically by variable name. # +# Note: use of (parentheses) and "quotes" can cause problems, so it is +# advisable to leave these out. Options_Desc_MAINTAINER=3D ports@FreeBSD.org @@ -9,7 +11,7 @@ AO_DESC?=3D Support libao audio library ARCHIVE_DESC?=3D Support bzip2/zip/iso9660 archive AVAHI_DESC?=3D Support Zeroconf through Avahi -CDDA2WAV_DESC?=3D Enable cdda2was CD ripper +CDDA2WAV_DESC?=3D Enable cdda2wav CD ripper CUE_DESC?=3D Support embedded cue sheets CURL_DESC?=3D Enable CURL support DAGRAB_DESC?=3D Enable dagrab CD ripper @@ -31,7 +33,7 @@ IPV6_DESC?=3D Enable IPv6 support JACK_DESC?=3D Support JACK audio server JPEG_DESC?=3D Enable JPEG support -LAME_DESC?=3D Support for MP3 Icecast Streams +LAME_DESC?=3D Support for LAME MP3 LASTFM_DESC?=3D Support Last.FM stream input LDAP_DESC?=3D Enable LDAP support MAGICK_DESC?=3D Enable ImageMagick Library http://www.bayofrum.net/~crees/patches/bsd.options.desc.mk-comment-special-= chars.diff