Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Dec 2008 17:00:14 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org
Subject:   svn commit: r185866 - in stable/7/sys: . contrib/pf dev/cxgb fs/nullfs
Message-ID:  <200812101700.mBAH0Ehq036977@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Dec 10 17:00:14 2008
New Revision: 185866
URL: http://svn.freebsd.org/changeset/base/185866

Log:
  MFC r185335:
  In null_lookup(), do the needed cleanup instead of panicing saying
  the cleanup is needed.
  
  Approved by:	re (kensmith)

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)
  stable/7/sys/fs/nullfs/null_vnops.c

Modified: stable/7/sys/fs/nullfs/null_vnops.c
==============================================================================
--- stable/7/sys/fs/nullfs/null_vnops.c	Wed Dec 10 16:20:49 2008	(r185865)
+++ stable/7/sys/fs/nullfs/null_vnops.c	Wed Dec 10 17:00:14 2008	(r185866)
@@ -365,11 +365,10 @@ null_lookup(struct vop_lookup_args *ap)
 			vrele(lvp);
 		} else {
 			error = null_nodeget(dvp->v_mount, lvp, &vp);
-			if (error) {
-				/* XXX Cleanup needed... */
-				panic("null_nodeget failed");
-			}
-			*ap->a_vpp = vp;
+			if (error)
+				vput(lvp);
+			else
+				*ap->a_vpp = vp;
 		}
 	}
 	return (error);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200812101700.mBAH0Ehq036977>