From owner-cvs-ports@FreeBSD.ORG Tue Aug 16 18:27:29 2005 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6791F16A420 for ; Tue, 16 Aug 2005 18:27:29 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: from smtp105.rog.mail.re2.yahoo.com (smtp105.rog.mail.re2.yahoo.com [206.190.36.83]) by mx1.FreeBSD.org (Postfix) with SMTP id 617BC43D5C for ; Tue, 16 Aug 2005 18:27:27 +0000 (GMT) (envelope-from adamw@magnesium.net) Received: (qmail 15508 invoked from network); 16 Aug 2005 18:27:26 -0000 Received: from unknown (HELO ?192.168.1.140?) (tacopants@70.28.168.125 with plain) by smtp105.rog.mail.re2.yahoo.com with SMTP; 16 Aug 2005 18:27:26 -0000 Message-ID: <4302300D.5040701@magnesium.net> Date: Tue, 16 Aug 2005 14:27:25 -0400 From: Adam Weinberger User-Agent: Mozilla Thunderbird 1.0+ (Macintosh/20050712) MIME-Version: 1.0 To: Kirill Ponomarew References: <200508160914.j7G9EiPd061656@repoman.freebsd.org> In-Reply-To: <200508160914.j7G9EiPd061656@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/deskutils/gourmet Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 18:27:29 -0000 Kirill Ponomarew wrote: > krion 2005-08-16 09:14:43 UTC > > FreeBSD ports repository > > Modified files: > deskutils/gourmet Makefile > Log: > Fix dependencies and build. > > Approved by: portmgr (implicit) This won't fix the build at all. Look at the pre-install: target. gourmet requires a python-enabled metakit, and the only way to achieve that is to have WITH_METAKIT_PYTHON=yes defined when building metakit. All you've accomplished here is ensuring that the port is still BROKEN, but in a different way. Your change may look better from the standpoint of pointyhat logs, but in reality, gourmet's dependency is more logically on libmk4py.so than on libmk4.so. The real issue lies within metakit. There is no python-enabled metakit slave port, and one cannot choose to enable python based solely upon whether python is already installed (you can only check for ${PYTHON_CMD} after bsd.port.pre.mk, but you can only define WITH_PYTHON *before* bsd.port.pre.mk... python could really use a WANT_PYTHON switch). I'd prefer to see this change backed out, but it doesn't make much difference either way. In the future, though, could you please run changes like this by me first? I recognize that you're doing your portmgrial duties here, but surely one of my maintainer-based rights is to challenge changes like this *before* they're committed. # Adam -- Adam Weinberger adamw@magnesium.net || adamw@FreeBSD.org adamw@vectors.cx || adamw@gnome.org http://www.vectors.cx