From owner-freebsd-net@FreeBSD.ORG Tue Jul 1 14:04:28 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 03D3E106566C for ; Tue, 1 Jul 2008 14:04:28 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from pele.citylink.co.nz (pele.citylink.co.nz [202.8.44.226]) by mx1.freebsd.org (Postfix) with ESMTP id 8F4C68FC0C for ; Tue, 1 Jul 2008 14:04:27 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by pele.citylink.co.nz (Postfix) with ESMTP id B374F2BE4B; Wed, 2 Jul 2008 02:04:26 +1200 (NZST) X-Virus-Scanned: Debian amavisd-new at citylink.co.nz Received: from pele.citylink.co.nz ([127.0.0.1]) by localhost (pele.citylink.co.nz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pAy1MBr69iBu; Wed, 2 Jul 2008 02:04:23 +1200 (NZST) Received: from citylink.fud.org.nz (unknown [202.8.44.45]) by pele.citylink.co.nz (Postfix) with ESMTP; Wed, 2 Jul 2008 02:04:23 +1200 (NZST) Received: by citylink.fud.org.nz (Postfix, from userid 1001) id 94B5F11430; Wed, 2 Jul 2008 02:05:50 +1200 (NZST) Date: Tue, 1 Jul 2008 07:05:50 -0700 From: Andrew Thompson To: Stefan Lambrev Message-ID: <20080701140550.GA379@citylink.fud.org.nz> References: <4868A34C.6030304@moneybookers.com> <20080630101629.GD79537@cdnetworks.co.kr> <20080701012531.GA92392@citylink.fud.org.nz> <4869FE2E.4070805@moneybookers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4869FE2E.4070805@moneybookers.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: Pyun YongHyeon , freebsd-net@freebsd.org Subject: Re: if_bridge turns off checksum offload of members? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2008 14:04:28 -0000 On Tue, Jul 01, 2008 at 12:51:42PM +0300, Stefan Lambrev wrote: > Hi, > > May be a stupid questions, but: > > 1) There are zero matches of IFCAP_TOE in kernel sources .. there is not > support for TOE in 7.0, but may be this is work in progress for 8-current? Yes, its in current only. Just remove IFCAP_TOE. > 2) In #define BRIDGE_IFCAPS_MASK (IFCAP_TOE|IFCAP_TSO|IFCAP_TXCSUM) - TOE > should be repleaced with RXCSUM or just removed? > 3) Why RX is never checked? In my case this doesn't matter because em turn > off both TX and RX if only one is disabled, but probably there is a > hardware, > that can separate them e.g. RX disabled while TX enabled? Rx does not matter, whatever isnt offloaded in hardware is just computed locally such as checking the cksum. Its Tx that messes up the bridge, if a outgoing packet is generated locally on an interface that has Tx offloading, it may actaully be sent out a different bridge member that does not have that capability. This would cause it to be sent with an invalid checksum for instance. The bridge used to just disable Tx offloading but this patch you are testing makes sure each feature is supported by all members. > 4) I'm not sure why bridge should not work with two interfaces one of which > support TX and the other does not? At least if I turn on checksum offload > only on one of the interfaces the bridge is still working ... > > Andrew Thompson wrote: > > - cut - >> >> >> This patch should do that, are you able to test it Stefan? >> >> >> cheers, >> Andrew >> > P.S. I saw very good results with netisr2 on a kernel from p4 before few > months .. are there any patches flying around so I can test them with > 7-STABLE? :) > > -- > > Best Wishes, > Stefan Lambrev > ICQ# 24134177 >