From owner-svn-src-head@FreeBSD.ORG Mon Dec 1 16:13:09 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC1D52E3; Mon, 1 Dec 2014 16:13:09 +0000 (UTC) Received: from mail-wi0-x233.google.com (mail-wi0-x233.google.com [IPv6:2a00:1450:400c:c05::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 52C3228B; Mon, 1 Dec 2014 16:13:09 +0000 (UTC) Received: by mail-wi0-f179.google.com with SMTP id ex7so17951194wid.0 for ; Mon, 01 Dec 2014 08:13:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Jqn5PnYeAyI1XcUPal+tEvlhSlTH+374Di2CldbJeT0=; b=ZcGyP6SwSWcUIefmTHV+rWCj+F3NKI9h+l4LdS9ZUvmZEJzEh7PyfOkOVe1fYLU2JI qEQ5rhjsnwZ4TVyLpd3yzpePyRXACP/oXfMAIk2KnqGNxspSIzDFA7qOJ4UPTarv/Buz zdElKgRkAB8oEiGiNs9E6Zi9xquRFe5gglVYwDgHUkyRx5eFNb4DvKKOLUILNMjjiTzV HbJgWVhP+50s6B5AIWBm/C+YkszPQ3gn+OrgXxidN/uV9BF84XTFdfbt5lQw4YQ9CSM+ Ot4+wsM9LNfMACLB/HpqjMDgWIJ44PGSN153Dfwr5mocTW7Vd7O7/U6mJv9rwSW6M1lo wHMQ== MIME-Version: 1.0 X-Received: by 10.180.99.1 with SMTP id em1mr86330439wib.29.1417450387617; Mon, 01 Dec 2014 08:13:07 -0800 (PST) Received: by 10.194.81.233 with HTTP; Mon, 1 Dec 2014 08:13:07 -0800 (PST) In-Reply-To: <92F537D5-E1C8-402E-9EDC-CB6270059BCA@mu.org> References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> <547C8A9C.4080603@selasky.org> <547C8CA2.8040305@selasky.org> <547C8DEF.5020809@selasky.org> <92F537D5-E1C8-402E-9EDC-CB6270059BCA@mu.org> Date: Mon, 1 Dec 2014 08:13:07 -0800 Message-ID: Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys From: Jack Vogel To: Alfred Perlstein Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: Hans Petter Selasky , "src-committers@freebsd.org" , John Baldwin , "svn-src-all@freebsd.org" , Alfred Perlstein , "svn-src-head@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Dec 2014 16:13:10 -0000 Really, and did I say that I approved, because I do not recall the event? Jack On Mon, Dec 1, 2014 at 8:08 AM, Alfred Perlstein wrote: > Jack you were asked. Please see the review system. > > Sent from my iPhone > > On Dec 1, 2014, at 8:05 AM, Jack Vogel wrote: > > There is no mystery about who's drivers these are, and its not like it > would > take a lot of effort to figure out ownership and ask us for review. > > Remove this commit until I have had time to look it over! > > Jack > > > On Mon, Dec 1, 2014 at 7:56 AM, Alfred Perlstein wrote: > >> >> >> > On Dec 1, 2014, at 7:49 AM, Hans Petter Selasky >> wrote: >> > >> >> On 12/01/14 16:45, Alfred Perlstein wrote: >> >> >> >> > Hi, >> >>> >> >>> It is quite early, actually: >> >>> >> >>> SYSINIT(sysctl, SI_SUB_KMEM, SI_ORDER_FIRST, sysctl_register_all, 0); >> >>> >> >>> In some parts of the machine independent, MI, code you neee to keep >> the TUNABLE_FETCH'es, because its run before SI_SUB_KMEM ! >> >> >> >> Then it will not work unless I move the global n_queues sysctl >> creation into the driver's mod load function. >> >> >> >> Is that ok? >> > >> > Are you asking me? >> >> In soviet russia no one is ever sure whom to ask for permission to >> proceed. >> >> (Also you have significant commits to the driver so it makes sense. ) >> >> >> > >> > --HPS >> > >> > >> >> >