From owner-freebsd-stable@freebsd.org Wed Nov 13 06:11:58 2019 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4415517F0E0 for ; Wed, 13 Nov 2019 06:11:58 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47CZ591jHJz4bGS; Wed, 13 Nov 2019 06:11:56 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl1-x643.google.com with SMTP id s10so621810plp.2; Tue, 12 Nov 2019 22:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SvGvgPzNe8Hqryd+rmiP7T/Z0HKiOYigOZl+6iNeDBw=; b=pVpFOJTWsI3ncjGEZ+3ZMHCj7O9B7iEXAjQm4ZpCzrVsYvzjqV7pFyI8pSlP2sw0l1 nvX2GD+ss4BjgQhBsD/MWARAipC79QOXPbLkvPVmBJ06tUTCBbHwmtAsif/ZtFtul73E J9tqYERIj2G8cWSeSCDVB2OlEu/bA0RY5wFy3s5qXoY5NYoftIwfgOyAyIMhlOZzJrtP ODS4lvb7KmJitCc1FGbc2Ive+86QBTaUP4REsTemKB/jogfRO2GiUfuJ0D3+ttX7+2U/ p5n+qvPKT2K4CrdaqHerM7TYeIezpOKgX7tceZW4HMx2lPMEAhFwc8ebPBUSq8E83NG/ TJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:cc:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=SvGvgPzNe8Hqryd+rmiP7T/Z0HKiOYigOZl+6iNeDBw=; b=ozwcbqnhmvJlSUuD2sDXa9ouISnZz510xL6p89vpI+JDcxxRr2qFcJaopDFP0l5ggz Icl2md8j4VyxUZ6KQ83frIXZV+LQUVouJVmNoNukmmA75M6YV1+J/3WsjmUxMyxYedrM RG1HBhWzW9CnihmM3TMJykszQd3kWCgcshWzxruOdou+rNBDx2Vy2mima+p0O4PwRaoC lHZ7M0YRAmfRESZXOvE8aKlr8WNRDWYds7pyfJjOf+YLWFUrN4Oy+qXqgwJ9mbYdjZMC +L4d9W3IQj500jsCf/xSmrw/HCVLpY3TiUOJPRqmcSl662KdHJypYA/TCZNxccELPNlC je6g== X-Gm-Message-State: APjAAAUwuJ2WuWYCJBtzJEF9fUqSoBQyoOx2b6om482jHZhyJFIUdXLD G3p8Vny8wt9RSxTS8stwBUYuD5kI X-Google-Smtp-Source: APXvYqzo6Y5Y6vV9avpziRLYot19apONXZgQ4UCLreEyEdmeIPwOk5DqPyggTB/HnqwnzPZhiyrIpw== X-Received: by 2002:a17:902:b681:: with SMTP id c1mr1945872pls.202.1573625515301; Tue, 12 Nov 2019 22:11:55 -0800 (PST) Received: from [192.168.1.110] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id w2sm1284991pfj.22.2019.11.12.22.11.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2019 22:11:54 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: syslogd truncating messages on FreeBSD >11.2-R To: Scott , FreeBSD stable References: <20191109030811.GA64882@thismonkey.com> Cc: Ed Schouten From: Kubilay Kocak Message-ID: <5265db9a-2eb2-6911-350a-aa1ed808da59@FreeBSD.org> Date: Wed, 13 Nov 2019 17:11:51 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Thunderbird/71.0 MIME-Version: 1.0 In-Reply-To: <20191109030811.GA64882@thismonkey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47CZ591jHJz4bGS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=pVpFOJTW; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::643 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-3.20 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; IP_SCORE(-1.00)[ip: (-0.64), ipnet: 2607:f8b0::/32(-2.33), asn: 15169(-2.00), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2019 06:11:58 -0000 On 9/11/2019 2:08 pm, Scott wrote: > Hi, > > please let me know if there is a better forum for this. > > As of 11.3-RELEASE syslogd truncates all forwarded messages to 480 bytes for > IPV4 and 1180 for IPv6. > > The change occurs in the added code: > > switch (f->f_type) { > case F_FORW: > /* Truncate messages to RFC 5426 recommended size. */ > dprintf(" %s", f->fu_forw_hname); > switch (f->fu_forw_addr->ai_addr->sa_family) { > #ifdef INET > case AF_INET: > dprintf(":%d\n", > ntohs(satosin(f->fu_forw_addr->ai_addr)->sin_port)); > iovlist_truncate(il, 480); > break; > #endif > > There's more code for IPv6 and the function iovlist_truncate itself. > > This change is not turned on by a switch and happens automatically, however I > can't find it documented in UPDATING or the release notes. I would have > thought that any change in default behaviour of the system should at least be > documented. > > Ideally this change would have been implemented via a switch given that the > RFC mentioned in the code (RFC 5426) does not mandate truncation, but > recommends it when the network MTU is not known. > > What's the best way to reach out to the maintainer to suggest a switch to > turn on this code? > > Thanks, > Scott Hi Scott, Looks like this came in in base r332510 [1] via: https://reviews.freebsd.org/D15011 The commit log message and review history may provide additional context for the behaviour change (I haven't reviewed them) I have CC'd the committer on this email, but in the meantime, and if you wouldn't mind, it is worth reporting the issue via Bugzilla, so that we track it, and so others can find it. [1] https://svnweb.freebsd.org/changeset/base/332510 -- Regards, koobs