From owner-freebsd-current Fri Feb 26 22:23: 3 1999 Delivered-To: freebsd-current@freebsd.org Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (Postfix) with ESMTP id 54E0B150F6 for ; Fri, 26 Feb 1999 22:22:51 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id WAA02475; Fri, 26 Feb 1999 22:15:49 -0800 (PST) Received: from current1.whistle.com(207.76.205.22) via SMTP by alpo.whistle.com, id smtpdsY2473; Sat Feb 27 06:15:49 1999 Date: Fri, 26 Feb 1999 22:15:47 -0800 (PST) From: Julian Elischer To: John Polstra Cc: dot@dotat.at, current@FreeBSD.ORG Subject: Re: mount -o union broken recently? In-Reply-To: <199902270516.VAA05738@vashon.polstra.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG you want to commit? (after you sir...) julian On Fri, 26 Feb 1999, John Polstra wrote: > In article , > Tony Finch wrote: > > Luigi Rizzo wrote: > > > > > >i just experienced the above today while trying diskless, and while > > >ls only seems to return the entries for the topmost directory, files > > >are accessible if you know the name. no idea if this is of any help. > > > > This is exactly the right pointer, thanks! The problem appears to be > > the change between revs 1.108 and 1.109 of sys/kern/vfs_syscalls.c. A > > couple of (very similar) blocks of code related to `mount -o union` > > seem to have been mixed up with some code related to `mount -t union` > > and therefore removed. It's a shame that the two things get confused > > so much. I originally missed vfs_syscalls.c because a `find > > /usr/src/sys | xargs grep MNT_UNION` on 3.1 didn't show it. Replacing > > the errant code fixes the problem. Here's a patch against 1.112.2.1. > > Great sleuthing, guys! > > John > -- > John Polstra jdp@polstra.com > John D. Polstra & Co., Inc. Seattle, Washington USA > "Nobody ever went broke underestimating the taste of the American public." > -- H. L. Mencken > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message