From owner-freebsd-bugs@FreeBSD.ORG Tue Aug 30 13:00:30 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C4A6916A41F for ; Tue, 30 Aug 2005 13:00:30 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5D6443D48 for ; Tue, 30 Aug 2005 13:00:29 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j7UD0THH027384 for ; Tue, 30 Aug 2005 13:00:29 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j7UD0Tdt027383; Tue, 30 Aug 2005 13:00:29 GMT (envelope-from gnats) Resent-Date: Tue, 30 Aug 2005 13:00:29 GMT Resent-Message-Id: <200508301300.j7UD0Tdt027383@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oliver Fromme Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D30B16A41F for ; Tue, 30 Aug 2005 12:50:34 +0000 (GMT) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (lurza.secnetix.de [83.120.8.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 75B6343D48 for ; Tue, 30 Aug 2005 12:50:33 +0000 (GMT) (envelope-from olli@lurza.secnetix.de) Received: from lurza.secnetix.de (lopipk@localhost [127.0.0.1]) by lurza.secnetix.de (8.13.1/8.13.1) with ESMTP id j7UCoViN089523; Tue, 30 Aug 2005 14:50:31 +0200 (CEST) (envelope-from oliver.fromme@secnetix.de) Received: (from olli@localhost) by lurza.secnetix.de (8.13.1/8.13.1/Submit) id j7UCoVin089522; Tue, 30 Aug 2005 14:50:31 +0200 (CEST) (envelope-from olli) Message-Id: <200508301250.j7UCoVin089522@lurza.secnetix.de> Date: Tue, 30 Aug 2005 14:50:31 +0200 (CEST) From: Oliver Fromme To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Oliver Fromme Subject: kern/85477: [patch] [trivial] fix driver message in if_xe.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Oliver Fromme List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2005 13:00:30 -0000 >Number: 85477 >Category: kern >Synopsis: [patch] [trivial] fix driver message in if_xe.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Aug 30 13:00:29 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Oliver Fromme >Release: HEAD, RELENG_6, RELENG_5 >Organization: secnetix GmbH & Co. KG, Munich, Germany >Environment: The patch applies to HEAD, RELENG_6 and RELENG_5. (In fact, the problem exists in all versions since rev 1.39 of if_xe.c which was introduced between 5.1-RELEASE and 5.2-RELEASE.) >Description: This is a trivial patch that fixes a small glitch in a message printed from the xe driver, resulting in a duplicate "0x0x" prefix. This message is only printed when the xe_debug level is 1 or larger (the default is 0). >How-To-Repeat: Use an xe card and set the xe_debug level to 1 (or larger), then watch the kernel messages. It's pretty obvious if you look at the patch. >Fix: --- src/sys/dev/xe/if_xe.c.orig Sun Aug 28 21:12:22 2005 +++ src/sys/dev/xe/if_xe.c Tue Aug 30 14:34:41 2005 @@ -293,7 +293,7 @@ } if (scp->ce2) { XE_SELECT_PAGE(0x45); - DEVPRINTF(1, (dev, "CE2 version = 0x%#02x\n", XE_INB(XE_REV))); + DEVPRINTF(1, (dev, "CE2 version = %#04x\n", XE_INB(XE_REV))); } /* Attach the interface */ >Release-Note: >Audit-Trail: >Unformatted: