From owner-freebsd-current Thu Jun 27 15:48:56 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id PAA03564 for current-outgoing; Thu, 27 Jun 1996 15:48:56 -0700 (PDT) Received: from critter.tfs.com ([140.145.16.108]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id PAA03557; Thu, 27 Jun 1996 15:48:53 -0700 (PDT) Received: from critter.tfs.com (localhost [127.0.0.1]) by critter.tfs.com (8.7.5/8.7.3) with ESMTP id PAA29891; Thu, 27 Jun 1996 15:48:22 -0700 (PDT) To: Nate Williams cc: "Jordan K. Hubbard" , Scott Blachowicz , current@FreeBSD.ORG Subject: Re: Building inside of /usr/src? In-reply-to: Your message of "Thu, 27 Jun 1996 16:10:13 MDT." <199606272210.QAA11833@rocky.mt.sri.com> Date: Thu, 27 Jun 1996 15:48:20 -0700 Message-ID: <29888.835915700@critter.tfs.com> From: Poul-Henning Kamp Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >> Ahem. Sorry, I feel better now! :-) >> >> Check this out in make: >> >> if ((pwd = getenv("PWD")) != NULL) { >> if (stat(pwd, &sb) == 0 && sa.st_ino == sb.st_ino && >> sa.st_dev == sb.st_dev) >> (void) strcpy(curdir, pwd); >> } >> >> Anyone else think that this is totally bogus and should be removed? >> It certainly EXPLAINS a few things! :-) > >Well, you already took it out, so I guess comments don't matter, but >there's *probably* a reason for doing it. You're best bet would be to >remove it *locally* and then test the change to see if bad things happen >before spamming the repository making us find all the bugs. :( It is a semi-bogus performance optimization, I remembet it came in the argument was that it would never fail, since the (dev#,ino#) would catch cases where it wasn't ok. I guess the stat should be a lstat ? -- Poul-Henning Kamp | phk@FreeBSD.ORG FreeBSD Core-team. http://www.freebsd.org/~phk | phk@login.dknet.dk Private mailbox. whois: [PHK] | phk@ref.tfs.com TRW Financial Systems, Inc. Future will arrive by its own means, progress not so.