Date: Sat, 24 Sep 2016 21:23:04 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Robert_Burmeister <robert.burmeister@utoledo.edu> Cc: freebsd-ports@freebsd.org Subject: Re: HTML5 videos crashes Firefox Message-ID: <D2D35AD2-DBA8-4628-B393-24C9C9815A47@FreeBSD.org> In-Reply-To: <1474623338662-6132220.post@n6.nabble.com> References: <56F804E9.8050506@netfence.it> <56FAAB3D.10906@netfence.it> <34cb33f2-69b0-aa43-1d98-6613713c8877@netfence.it> <b2ba6bbf-c313-aaf9-b83b-ec9c6848ceb9@netfence.it> <1474623338662-6132220.post@n6.nabble.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_96BF9AAA-D602-4A25-965E-AEFD531B843D Content-Type: multipart/mixed; boundary="Apple-Mail=_E27B1FA4-68E2-4E49-8A4E-0E5F8D8FB5A4" --Apple-Mail=_E27B1FA4-68E2-4E49-8A4E-0E5F8D8FB5A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 23 Sep 2016, at 11:35, Robert_Burmeister = <robert.burmeister@utoledo.edu> wrote: > I was able to resolve HTML5 videos crashes in Firefox 49 on FreeBSD = 10.3 i386 > by changing the FFMPEG compile option to "SSE=3Doff" and recompiling = FFMPEG. >=20 > The LLVM compiler was not dealing with an SSE bug on my older core2 = CPU. I can't reproduce your particular crashes, but in the past I had created a patch to force the FFmpeg build to use stack realignment. Can you please try it out? E.g. put the attched patch in the root of your ports folder, and run: patch -p0 -f -F0 -i multimedia__ffmpeg-force-i386-stack-realign-1.diff This patch is needed, because FFmpeg assumes a 16-byte aligned stack, even on i386, where the ABI specifies a 4-byte alignment. On Linux, this ABI requirement was basically dumped at some point, leaving old applications in the cold, but not on FreeBSD. -Dimitry --Apple-Mail=_E27B1FA4-68E2-4E49-8A4E-0E5F8D8FB5A4 Content-Disposition: attachment; filename=multimedia__ffmpeg-force-i386-stack-realign-1.diff Content-Type: application/octet-stream; name="multimedia__ffmpeg-force-i386-stack-realign-1.diff" Content-Transfer-Encoding: 7bit Index: multimedia/ffmpeg/files/patch-configure =================================================================== --- multimedia/ffmpeg/files/patch-configure (revision 422403) +++ multimedia/ffmpeg/files/patch-configure (working copy) @@ -14,6 +14,19 @@ cpu="generic" intrinsics="none" +@@ -5682,7 +5677,11 @@ elif enabled gcc; then + elif enabled llvm_gcc; then + check_cflags -mllvm -stack-alignment=16 + elif enabled clang; then +- check_cflags -mllvm -stack-alignment=16 ++ if enabled x86_32; then ++ check_cflags -mllvm -stack-alignment=16 ++ check_cflags -mstack-alignment=16 ++ check_cflags -mstackrealign ++ fi + check_cflags -Qunused-arguments + check_cflags -Werror=implicit-function-declaration + check_cflags -Werror=missing-prototypes @@ -5823,7 +5818,7 @@ ifndef MAIN_MAKEFILE SRC_PATH:=\$(SRC_PATH:.%=..%) endif --Apple-Mail=_E27B1FA4-68E2-4E49-8A4E-0E5F8D8FB5A4-- --Apple-Mail=_96BF9AAA-D602-4A25-965E-AEFD531B843D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlfm0pwACgkQsF6jCi4glqMrvgCfXv/2itnrZ+oTrRoGbwM2sR4L cjAAoO0Z2Q6RXJB8y3Vzi4QR1LQiHmF2 =1cwx -----END PGP SIGNATURE----- --Apple-Mail=_96BF9AAA-D602-4A25-965E-AEFD531B843D--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2D35AD2-DBA8-4628-B393-24C9C9815A47>