From owner-svn-src-head@FreeBSD.ORG Tue Jun 9 13:41:50 2015 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 79E8AB11 for ; Tue, 9 Jun 2015 13:41:50 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from vfemail.net (ninezero.vfemail.net [96.30.253.190]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F3C941334 for ; Tue, 9 Jun 2015 13:41:49 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: (qmail 84361 invoked by uid 89); 9 Jun 2015 13:41:47 -0000 Received: from localhost (HELO freequeue.vfemail.net) (127.0.0.1) by localhost with (DHE-RSA-AES256-SHA encrypted) SMTP; 9 Jun 2015 13:41:47 -0000 Received: (qmail 84265 invoked by uid 89); 9 Jun 2015 13:41:30 -0000 Received: by simscan 1.3.1 ppid: 84257, pid: 84261, t: 0.0049s scanners:none Received: from unknown (HELO smtp102-2.vfemail.net) (172.16.100.62) by FreeQueue with SMTP; 9 Jun 2015 13:41:30 -0000 Received: (qmail 23850 invoked by uid 89); 9 Jun 2015 13:41:30 -0000 Received: by simscan 1.4.0 ppid: 23833, pid: 23847, t: 0.7519s scanners:none Received: from unknown (HELO nil) (amJlaWNoQHZmZW1haWwubmV0@172.16.100.27) by 172.16.100.62 with ESMTPA; 9 Jun 2015 13:41:29 -0000 From: Jan Beich To: Andriy Gapon Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r284107 - head/sys/cddl/compat/opensolaris/sys In-Reply-To: <5576CA36.8060403@FreeBSD.org> (Andriy Gapon's message of "Tue, 09 Jun 2015 14:12:54 +0300") References: <201506070854.t578sPdR012092@svn.freebsd.org> <5576CA36.8060403@FreeBSD.org> Date: Tue, 09 Jun 2015 15:41:20 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 13:41:50 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Andriy Gapon writes: > On 09/06/2015 13:31, Jan Beich wrote: > >> Andriy Gapon writes: >>=20 >>> Author: avg Date: Sun Jun 7 08:54:25 2015 New Revision: 284107 URL: >>> https://svnweb.freebsd.org/changeset/base/284107 >>>=20 >>> Log: compat nvpair.h: make sure that the names are mangled only for >>> kernel >>>=20 >>> Currently there is no good reason to mangle the userland API. The change >>> was introduced in eac1d566b46edef765754203bef22c75c1699966, r279437. >>> Also see https://reviews.freebsd.org/D1881. >>=20 >> Can you bump __FreeBSD_version? At least sysutils/geomWatch requires it. >>=20 >> https://svnweb.freebsd.org/changeset/ports/388906 > > There should have been a bug report and an src fix instead of (parts of) > https://svnweb.freebsd.org/ports?view=3Drevision&revision=3D386870 Good point. However, opensolaris libs have unclear ABI guarantees. Their API is not exposed but the libs aren't marked PRIVATELIB. Some symbols are removed on updates *without* corresponding SHLIB_MAJOR bumps. libnvpair is mostly unchanged between 8.4R and 11.0C, though. # shouldn't be possible without libzfs.so.2 in libmap.conf /poudriere/jails/84amd64/sbin/zfs: Undefined symbol "zpool_set_history_st= r" > I wonder why the libnvpair ABI breakage was silently accepted but the ABI= fix > requires some special magic... I'll probably back out ports@386870 and ports@388906 after a while. libnvpair with bogus ABI existed on 11.0C for 3 months, enough to end up in the binary snapshots a few times. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVdu0BXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bfxUH/2kCi9/CAIjb90ezNIc4a5Bh HmOJAzs0Md+8mTVkSbuTHnsHDlbL8qmh+2QwahyNHAmesNVEFYcjZEbyKyi4yDJR +6/VDTIwKgQcUg0BGPfJGSU7q5sIZv6lvpizYR81uWE4YNkP5j1yCOCIPlfBuiR3 ymhbVipyMdev3tlAh0nhwsXHiQjNJ50C41a9Gl0J4ZWhn50EO1mATGeJ3W9MqfWd PUyH39YZDE+IWpPOfgXYwHyzCbrcAt9EHN7tk/pFKgLdd5vs0ggsh5cYDrIlzpDU l5QjCghc6zBSqDWeFimLkOM/zGN60/Y6VyE9QFIPceLUSfg3tuT1oC30gOzolYU= =ny3y -----END PGP SIGNATURE----- --=-=-=--