From owner-svn-src-head@freebsd.org Mon Feb 19 22:37:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A004AF053E7 for ; Mon, 19 Feb 2018 22:37:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 14C677024A for ; Mon, 19 Feb 2018 22:37:11 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 56ffe470-15c5-11e8-b951-f99fef315fd9 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id 56ffe470-15c5-11e8-b951-f99fef315fd9; Mon, 19 Feb 2018 22:36:35 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w1JMb4Po055894; Mon, 19 Feb 2018 15:37:04 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1519079823.91697.30.camel@freebsd.org> Subject: Re: svn commit: r329609 - head/stand/lua From: Ian Lepore To: Kyle Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 19 Feb 2018 15:37:03 -0700 In-Reply-To: <201802192229.w1JMTG9C082624@repo.freebsd.org> References: <201802192229.w1JMTG9C082624@repo.freebsd.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 22:37:12 -0000 On Mon, 2018-02-19 at 22:29 +0000, Kyle Evans wrote: > > +                       -- Swap the first two menu entries > +                       menu_entries[1], menu_entries[2] = menu_entries[2], > +                           menu_entries[1]; >   IMO, this is the sort of unreadable insanity that comes from having inflexible rules about line-wrapping which trump readability.  The original code could be easily understood.  The suggested replacement,  menu_entries[1], menu_entries[2] =     menu_entries[2], menu_entries[1] Was also pretty readable, although not as much as it would be if it were all on one line.  But splitting the line at the whitespace nearest to 80 columns just creates an unreadable mess for the insignificant virtue of following some arbitrary rule.  (Which is why I very often ignore that rule and split lines at the point < 80 which makes the most sense for understanding the code, even if that means splitting at column 30.) -- Ian