From owner-freebsd-current@FreeBSD.ORG  Wed Nov  9 01:51:42 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9D11106566C
	for <freebsd-current@freebsd.org>; Wed,  9 Nov 2011 01:51:42 +0000 (UTC)
	(envelope-from rysto32@gmail.com)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 82CBA8FC0A
	for <freebsd-current@freebsd.org>; Wed,  9 Nov 2011 01:51:42 +0000 (UTC)
Received: by wyg36 with SMTP id 36so1574945wyg.13
	for <freebsd-current@freebsd.org>; Tue, 08 Nov 2011 17:51:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=YwfV5Lwjr5KrVHXLvRzkQSAGjs67Hhxniq+n1OjuiPY=;
	b=QyYhfDv820bqnkmYdc52iAGqDn+njlywN4USe81lmw0hUBgKYrW8JRHBYP80iF07gw
	FuZTGnDWaw6WjBfnzmr4AmZX9/7w5y4uJuzr76x1bMRhmDTQwCnyEVIXrOO84NsklLjx
	TM20tOJuPjPfKX2RcYjwJwFJaslHo7Cvze1VY=
MIME-Version: 1.0
Received: by 10.180.7.97 with SMTP id i1mr368604wia.23.1320803501282; Tue, 08
	Nov 2011 17:51:41 -0800 (PST)
Received: by 10.180.8.34 with HTTP; Tue, 8 Nov 2011 17:51:41 -0800 (PST)
In-Reply-To: <CAMwoQQ7Qa29eZnEKDmeVjx723AOejSWm+ffgffEP3ZUUUuvzGA@mail.gmail.com>
References: <CAMwoQQ7Qa29eZnEKDmeVjx723AOejSWm+ffgffEP3ZUUUuvzGA@mail.gmail.com>
Date: Tue, 8 Nov 2011 20:51:41 -0500
Message-ID: <CAFMmRNyvDGJB=vUV=JXYtELxo=U21PiOAH_m_6hRmCQ9pJj26g@mail.gmail.com>
From: Ryan Stone <rysto32@gmail.com>
To: Paul Ambrose <ambrosehua@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-current <freebsd-current@freebsd.org>
Subject: Re: config(8) does not add post-processing for source file with
 compile-with command in sys/conf/files
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Nov 2011 01:51:43 -0000

On Tue, Oct 18, 2011 at 10:21 PM, Paul Ambrose <ambrosehua@gmail.com> wrote:
> when I digged the a PR(bin/160275), I found in_proto.c and
> if_ethersubr.c ( see sys/conf/files ) does not get
> ${NORMAL_CTFCONVERT} post-processing in Makefile
> (/usr/obj/usr/src/sys/MYKERNEL/Makefile) generated by config(8), so
> the objs does not contain ctf section

Here's a second attempt at this one.  I think that this version is
much cleaner than the other options in this thread.  If it survives a
make universe I intend to commit this:

Index: usr.sbin/config/mkmakefile.c
===================================================================
--- usr.sbin/config/mkmakefile.c        (revision 227341)
+++ usr.sbin/config/mkmakefile.c        (working copy)
@@ -762,16 +762,21 @@
                                break;
                        }
                        snprintf(cmd, sizeof(cmd),
-                           "${%s_%c%s}\n\t@${NORMAL_CTFCONVERT}", ftype,
+                           "${%s_%c%s}\n", ftype,
                            toupper(och),
                            ftp->f_flags & NOWERROR ? "_NOWERROR" : "");
                        compilewith = cmd;
                }
                *cp = och;
                if (strlen(ftp->f_objprefix))
-                       fprintf(f, "\t%s $S/%s\n\n", compilewith, np);
+                       fprintf(f, "\t%s $S/%s\n", compilewith, np);
                else
-                       fprintf(f, "\t%s\n\n", compilewith);
+                       fprintf(f, "\t%s\n", compilewith);
+
+               if (!(ftp->f_flags & NO_OBJ))
+                       fprintf(f, "\t@${NORMAL_CTFCONVERT}\n\n");
+               else
+                       fprintf(f, "\n");
        }
 }