From owner-cvs-ports@FreeBSD.ORG Wed May 2 08:48:13 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4639F1065675; Wed, 2 May 2012 08:48:13 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from megatron.madpilot.net (megatron.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id CAC9B8FC24; Wed, 2 May 2012 08:48:12 +0000 (UTC) Received: from megatron.madpilot.net (localhost [127.0.0.1]) by megatron.madpilot.net (Postfix) with ESMTP id 3VjCn743Kyz2D2; Wed, 2 May 2012 10:48:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received; s=mail; t=1335948485; x= 1337762886; bh=a+CvhyLeP7p25nyXokYk3lBW6n2+bCcFhTwqXctKGTA=; b=s jjWOUG8wp9hv234I+pxy4MjLvDBRaSb2Qj3PM6FF9Or+Ivyzz95l92iTxKoTMzMZ Z0vc/zq0IONPV06gdC7E1CNaoGfltY1u600k3B+BQstNVlwSUOTtC2qmzidtdJ98 92mPeapDkjsP7mfnqZgety/J81cwE2i2wdLc/WCv9E= X-Virus-Scanned: amavisd-new at madpilot.net Received: from megatron.madpilot.net ([127.0.0.1]) by megatron.madpilot.net (megatron.madpilot.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2byzQVRYGgJq; Wed, 2 May 2012 10:48:05 +0200 (CEST) Received: by megatron.madpilot.net (Postfix, from userid 1000) id 3VjCn14kC8z2D1; Wed, 2 May 2012 10:48:05 +0200 (CEST) Date: Wed, 2 May 2012 10:48:05 +0200 From: Guido Falsi To: nemysis Message-ID: <20120502084805.GA83818@megatron.madpilot.net> References: <201204301752.q3UHquWJ034347@repoman.freebsd.org> <20120501204522.GA23385@server.vk2pj.dyndns.org> <20120501234357.792c2599@nemysis3now.no-ip.biz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline In-Reply-To: <20120501234357.792c2599@nemysis3now.no-ip.biz> X-Operating-System: FreeBSD 9.0-STABLE User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Peter Jeremy , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Chris Rees , Thomas Abthorpe , cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/graphics Makefile ports/graphics/viewnior Makefile distinfo pkg-descr pkg-plist ports/graphics/viewnior/files patch-po_Makefile.in.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2012 08:48:13 -0000 --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 01, 2012 at 11:43:57PM +0200, nemysis wrote: > On Wed, 2 May 2012 06:45:22 +1000 > Peter Jeremy wrote: > > > On 2012-Apr-30 17:52:56 +0000, Guido Falsi wrote: > > > This is Viewnior, an image viewer program. Created to be simple, fast > > > and elegant. It's minimalistic interface provides more screenspace for > > > your images. Among its features are: > > > > This looks interesting, thanks. > > > > I notice that NLS is a configure-time option but USE_GETTEXT is > > unconditionally set (as well as being set within the !WITHOUT_NLS > > condtiional block). I presume this is a cut-and-paste error. > > > > > I have seen that in FreeBSD Ports collection is older version as you have > give me and i have adjusted. > > diff -ruN viewnior.old viewnior > viewnior.diff > > Should I this send to freebsd-ports-bugs@freebsd.org I see that the problem is caused by USE_GETTEXT being defined both unconditionally and in the option check. Sorry, this is my fault. If you approve I'd commit the attached simple fix. -- Guido Falsi --d6Gm4EdcadzBjdND Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="viewnior.diff" Index: Makefile =================================================================== RCS file: /home/ncvs/ports/graphics/viewnior/Makefile,v retrieving revision 1.1 diff -u -r1.1 Makefile --- Makefile 30 Apr 2012 17:52:55 -0000 1.1 +++ Makefile 2 May 2012 08:44:54 -0000 @@ -20,7 +20,6 @@ GNU_CONFIGURE= yes USE_AUTOTOOLS= autoconf -USE_GETTEXT= yes USE_GMAKE= yes USE_GNOME= glib20 gtk20 intltool pkgconfig INSTALLS_ICONS= yes --d6Gm4EdcadzBjdND--