From owner-svn-src-head@FreeBSD.ORG Tue Feb 26 18:35:56 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 79243EC0; Tue, 26 Feb 2013 18:35:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 55FFC1716; Tue, 26 Feb 2013 18:35:56 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 84E42B958; Tue, 26 Feb 2013 13:35:55 -0500 (EST) From: John Baldwin To: Davide Italiano Subject: Re: svn commit: r247300 - in head: sys/sys usr.bin/truss Date: Tue, 26 Feb 2013 13:35:30 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p25; KDE/4.5.5; amd64; ; ) References: <201302260213.r1Q2D2N1016801@svn.freebsd.org> <201302260941.52534.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201302261335.38001.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 26 Feb 2013 13:35:55 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2013 18:35:56 -0000 On Tuesday, February 26, 2013 12:09:42 pm Davide Italiano wrote: > On Tue, Feb 26, 2013 at 3:41 PM, John Baldwin wrote: > > On Monday, February 25, 2013 9:13:02 pm Xin LI wrote: > >> Author: delphij > >> Date: Tue Feb 26 02:13:02 2013 > >> New Revision: 247300 > >> URL: http://svnweb.freebsd.org/changeset/base/247300 > >> > >> Log: > >> Expose timespec and timeval macros when __BSD_VISIBLE is defined. This > >> allows userland application to use the following macros: > >> > >> timespecclear, timespecisset, timespeccmp, timespecadd, > >> timespecsub; > >> > >> timevalclear, timevalisset, timevalcmp. > > > > Why not fix truss to use the stock functions instead of keeping private > > "unusual" versions? > > > > -- > > John Baldwin > > time.h is already a mess in terms of namespace pollution, and this > exposure might not help thing. > Other details here: > http://permalink.gmane.org/gmane.os.freebsd.architechture/15518 I think that is orthogonal. Even if this is reverted I think truss should be changed to use the "normal" timespecsubt() macro rather than using a custom one with a different argument order. -- John Baldwin