Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Apr 2010 10:13:07 -0700
From:      Randall Stewart <rrs@lakerest.net>
To:        "Jayachandran C." <c.jayachandran@gmail.com>
Cc:        freebsd-mips@freebsd.org
Subject:   Re: Fix for pmap.c
Message-ID:  <3FC8C451-8FE2-4761-8A64-28761E07FEF2@lakerest.net>
In-Reply-To: <4bdb0900.0d67f10a.0ae4.7784@mx.google.com>
References:  <4bdb0900.0d67f10a.0ae4.7784@mx.google.com>

next in thread | previous in thread | raw e-mail | index | archive | help
JC:

Thats definitely a bug and would only effect those that have
 >512Meg of memory.

I have committed for you in rev 207441

R
On Apr 30, 2010, at 9:48 AM, Jayachandran C. wrote:

> There seems to be a obvious bug in the current pmap.c, can you please
> review/apply the patch below.
>
> This seems to be the cause of the crashes I'm seeing in HEAD. I'm  
> still
> testing with the patch, the buildworld I use will have to run a few  
> more
> hours to be completely sure that this is the problem.
>
> JC.
>
>
> Index: sys/mips/mips/pmap.c
> ===================================================================
> --- sys/mips/mips/pmap.c	(revision 207433)
> +++ sys/mips/mips/pmap.c	(working copy)
> @@ -236,7 +236,7 @@
> 	sched_pin();							\
> 	va1 = sysm->base;						\
> 	va2 = sysm->base + PAGE_SIZE;					\
> -	npte = mips_paddr_to_tlbpfn(phys2) |				\
> +	npte = mips_paddr_to_tlbpfn(phys1) |				\
> 	    PTE_RW | PTE_V | PTE_G | PTE_W | PTE_CACHE;			\
> 	pte = pmap_pte(kernel_pmap, va1);				\
> 	*pte = npte;							\
>

------------------------------
Randall Stewart
803-317-4952 (cell)
803-345-0391(direct)




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FC8C451-8FE2-4761-8A64-28761E07FEF2>