From owner-cvs-src@FreeBSD.ORG  Wed Mar 19 08:09:57 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A0F3106564A;
	Wed, 19 Mar 2008 08:09:57 +0000 (UTC)
	(envelope-from jroberson@chesapeake.net)
Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com
	[216.240.101.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 7DC978FC2A;
	Wed, 19 Mar 2008 08:09:51 +0000 (UTC)
	(envelope-from jroberson@chesapeake.net)
Received: from [192.168.1.107] (cpe-24-94-75-93.hawaii.res.rr.com
	[24.94.75.93]) (authenticated bits=0)
	by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id
	m2J89kEA079893; Wed, 19 Mar 2008 04:09:47 -0400 (EDT)
	(envelope-from jroberson@chesapeake.net)
Date: Tue, 18 Mar 2008 22:10:38 -1000 (HST)
From: Jeff Roberson <jroberson@chesapeake.net>
X-X-Sender: jroberson@desktop
To: David Xu <davidxu@FreeBSD.org>
In-Reply-To: <47E0C49D.8010807@freebsd.org>
Message-ID: <20080318220908.R910@desktop>
References: <200803190735.m2J7ZEhO000502@repoman.freebsd.org>
	<47E0C49D.8010807@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, Jeff Roberson <jeff@FreeBSD.org>,
	src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern subr_sleepqueue.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Mar 2008 08:09:57 -0000

On Wed, 19 Mar 2008, David Xu wrote:

> Jeff Roberson wrote:
>> jeff        2008-03-19 07:35:14 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/kern             subr_sleepqueue.c   Log:
>>    - At the top of sleepq_catch_signals() lock the thread and check 
>> TDF_NEEDSIGCHK
>>      before doing the very expensive cursig() and related locking. 
>> NEEDSIGCHK
>>      is updated whenever our signal mask change or when a signal is 
>> delivered and
>>      should be sufficient to avoid the more expensive tests.  This 
>> eliminates
>>      another source of PROC_LOCK contention in multithreaded programs.
>>     Revision  Changes    Path
>>   1.50      +12 -4     src/sys/kern/subr_sleepqueue.c
>> 
>
> This may break process suspension, a more completed patch is here: (though it 
> is outdated):
>
> http://people.freebsd.org/~davidxu/patch/PCATCH_optimize.patch
>
> In one word, process suspending may be in progress, and the thread
> should check it.

Thanks Xu.  I will add your NEEDSUSPCHECK flag and check that as well.

>
> Regards,
> David Xu
>
>