From owner-freebsd-hackers Sat Mar 25 12:43:35 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from rover.village.org (rover.village.org [204.144.255.49]) by hub.freebsd.org (Postfix) with ESMTP id 289A237B51B for ; Sat, 25 Mar 2000 12:43:27 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (harmony.village.org [10.0.0.6]) by rover.village.org (8.9.3/8.9.3) with ESMTP id NAA46355 for ; Sat, 25 Mar 2000 13:43:22 -0700 (MST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.9.3/8.8.3) with ESMTP id NAA73526 for ; Sat, 25 Mar 2000 13:43:12 -0700 (MST) Message-Id: <200003252043.NAA73526@harmony.village.org> To: hackers@freebsd.org Subject: Shim Code #error needed Date: Sat, 25 Mar 2000 13:43:12 -0700 From: Warner Losh Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I've been burned about 6 times now by the shim device support becoming optional. Oh well, that's current. However, I was thinking that it would be nice if there was something simple to grep for to see what drivers still needed to be converted. What would people think of my adding the following to the shim using devices: cvs diff: Diffing . Index: amd.c =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/pci/amd.c,v retrieving revision 1.3 diff -u -r1.3 amd.c --- amd.c 2000/01/14 03:39:30 1.3 +++ amd.c 2000/03/25 18:07:31 @@ -50,6 +50,10 @@ /* #define AMD_DEBUG0 */ /* #define AMD_DEBUG_SCSI_PHASE */ +#ifndef COMPAT_OLDPCI +#error "The amd device requires the old pci compatibility shims" +#endif + #include #include At least this way you get a decent error message when it fails to work. Comments? Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message