Date: Tue, 5 Feb 2019 17:22:28 +0000 From: Brooks Davis <brooks@freebsd.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Bruce Evans <brde@optusnet.com.au>, Ed Maste <emaste@freebsd.org>, Will Andrews <will@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325728 - head/lib/libkvm Message-ID: <20190205172228.GC71053@spindle.one-eyed-alien.net> In-Reply-To: <b5bb8301-9793-a37b-0721-6ce70a1fd4de@FreeBSD.org> References: <201711112330.vABNUwXC077395@repo.freebsd.org> <CAPyFy2BwNGHkMjj2rG5N5S=7E8N=9jfAUBki1L8eCY3kMeM8fw@mail.gmail.com> <20190205202145.A1080@besplex.bde.org> <CAPyFy2C%2BZ0aOGUBbgpLZ8sJbaN2YhEbR1YkV9Ya7POTSsbLqGQ@mail.gmail.com> <20190206024025.X3175@besplex.bde.org> <b5bb8301-9793-a37b-0721-6ce70a1fd4de@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 05, 2019 at 09:14:46AM -0800, John Baldwin wrote: > On 2/5/19 8:25 AM, Bruce Evans wrote: > > On Tue, 5 Feb 2019, Ed Maste wrote: > >=20 > >> On Tue, 5 Feb 2019 at 05:17, Bruce Evans <brde@optusnet.com.au> wrote: > >>> > >>> On Mon, 4 Feb 2019, Ed Maste wrote: > >>>> This should probably be uin64_t to support cross-debugging cores from > >>>> 64-bit machines on 32-bit hosts; also for i386 PAE. Or, on IRC jhb > >>>> suggested we introduce a kpaddr_t typedef akin to kvaddr_t. > >>> > >>> The correct type is vm_paddr_t or maybe a kvm wrapper of this. > >> > >> That precludes cross-arch and cross-size use of kvm_walk_pages; kvm > >> supports this use (see kvm_read2) so it should be a 64-bit kvm > >> wrapper. > >=20 > > kvm or system? kvaddr_t is system and the corresponding physical addre= ss > > type should probably be system too. >=20 > It only needs to exist for libkvm. I want to make a 'portable' libkvm th= at > can be built on non-FreeBSD OS's such as OS X, etc. That is the last thi= ng > needed to let kgdb run on non-FreeBSD OS's to cross-debug crash dumps. F= or > that you would want self-contained types I think such as kvm_vaddr_t and > kvm_paddr_t. I guess I just reused kvaddr_t because it already existed, > but having dedicated types in kvm.h is probably better long term. IIRC, you created kvaddr_t first and I co-opted it for the kernel after finding a namespace collision when I merged the kvaddr_t from CheriBSD. Using kvm_ types seems like a good idea for the reaons you hilight. -- Brooks --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJcWcZUAAoJEKzQXbSebgfAfRwIAJngvj8MVE/zTdmdixHoAXu6 ngkxu1AXO7bRwAmDfeaUOfGWeyD45J5mi7D8DG56hlxRJiIj4lx6osAwcx3zgUgE /ZJ0UWJFBKIkuGTjX0gQofaBh0ZhDHn8TXWuZOxKSpZY/1TMgJkgS+6UmHI5PTka MEhc3/U0Kj2F76NWG6gqDhLplZY55yqrhDDx/kz9wNTooSziPlyrOnRUa8ACxxSx L1FQd746woAuV2H6c0r8NaMx4Q5PVpzzXk/pNZefW1O7dj4prOYn0IUms5RMXE64 BQqLm5oEZYHmsHNCnns3hNLoqh/qF6Fl1B2vXo/r7EiZBFWKQGH0bLEy7xwRSlY= =YmcG -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190205172228.GC71053>